Repository navigation
chore(deps): bump mermaid from 11.16.1 to 12.1.0 - #3863
dependabot[bot] wants to merge 1 commit into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Codex review: blocked before merge. What this changesThis PR upgrades Mermaid to 12.1.0 and explicitly preserves Dagre layout and classic appearance in the shared Markdown renderer. Example: A published SKILL.md contains
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness⛔ Blocked before merge - 2 items remain Keep this PR open: current main still uses Mermaid 11.16.1, and maintainer-engaged work remains on browser compatibility; the earlier appearance finding is resolved. Priority: P2 Before merge
FindingsNone. Tests
Agent review detailsHow this fits togetherSkill pages, plugin READMEs, and scanner reports pass Markdown into MarkdownPreview, which loads Mermaid for diagram fences and displays SVG or the original source on failure. flowchart TD
A[Skill and plugin Markdown] --> B[MarkdownPreview]
B --> C[Mermaid fence detection]
C --> D[Mermaid initialization]
D --> E[Diagram rendering]
E --> F[SVG display]
E --> G[Source fallback]
Technical reviewBest possible solution: Keep the explicit appearance settings and land the upgrade only after Safari 15 compatibility is established, retaining Mermaid 11 if it cannot be preserved. Do we have a high-confidence way to reproduce the issue? This is dependency maintenance rather than a reported current-main bug; the browser-floor mismatch is source-verified, but no Safari runtime failure was reproduced. Is this the best way to solve the issue? The shared renderer is the correct place to preserve appearance; changing the browser target would broaden scope, so qualify the bundle and repair only demonstrated incompatibilities. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 0bf64843c697. Merge-risk optionsMaintainer options:
Provenance checked
TestingProof path: unit tests only. SecurityNone. EvidenceWhat I checked:
Likely related people:
Review metrics
LabelsLabel changes:
Label justifications:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment HistoryReview history (38 earlier review cycles; latest 8 shown)
Reviewed October 14, 2026, 2:20 AM ET / 06:20 UTC (Revision 39). |
7362f85 to
96c8394
Compare
96c8394 to
4a55f4b
Compare
Keep Dagre and classic appearance explicit at the shared Markdown renderer while upgrading Mermaid to 12.1.0. Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4a55f4b to
b87f9c9
Compare
|
@clawsweeper re-review |
|
🦞👀 Re-review progress:
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This comment has been minimized.
This comment has been minimized.
|
Audit at b87f9c9: appearance is explicitly pinned to neutral/Dagre/classic, and CI now passes after retrying the isolated local Convex capacity failure. This remains open because Mermaid 12 documents a Safari 17.4/ES2024 floor while our production bundle targets Safari 15 (vite.config.ts). The new parser graph includes Object.groupBy, which requires Safari 17.4; syntax transpilation alone does not establish runtime compatibility. The reviewed preview requires Vercel SSO, so no real candidate browser capture or Safari 15 proof is claimed. Before landing, qualify the actual built renderer on the supported browser floor and supply any demonstrated, narrowly scoped compatibility repair. Upstream contract: https://github.com/mermaid-js/mermaid/releases/tag/mermaid%4012.0.0 |
|
Closing this optional major upgrade while ClawHub keeps its Safari 15 browser target and Mermaid 11.16.1. Mermaid 12 declares Safari 17.4+ support. I tested its published 12.1.0 bundle with ClawHub’s neutral/strict/Dagre/classic settings: the official This was a focused missing-API simulation in Chromium, not a full Safari 15 run. Flowchart, sequence, and architecture examples passed with |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps mermaid from 11.16.1 to 12.1.0.
Release notes
Sourced from mermaid's releases.
... (truncated)
Commits
21f72f0Merge pull request #8360 from mermaid-js/changeset-release/master3f89f7bVersion Packages4ef0218Merge pull request #8358 from mermaid-js/release/12.0.1f45c691Fix error from build docsd9cb282Fix label overlap bug47fffa0Merge pull request #8297 from pentaoa/fix/eventmodeling-duplicate-frame-ids12c280eMerge develop and preserve eventmodeling regression testsc0f7052Merge pull request #8296 from pentaoa/fix/eventmodeling-reset-explicit-relations4f6ac96Merge pull request #8345 from mermaid-js/bug/8283_xychart-legend-clip-title-h...679093aMerge pull request #8344 from mermaid-js/pebr/issue-8292-elk-label