Edmonton #333
Closed
Edmonton #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmckinney
reviewed
May 8, 2024
There was a problem hiding this comment.
Hmm, CanadianJurisdiction in utils.py automatically creates these based on the contents of country-ca.csv. Maybe you or @seamuslee001 can make a PR to https://github.com/opencivicdata/ocd-division-ids to update the names there, and then we can update the CSV here? (the CSV is out of date in general)
|
I made a pull request to update |
|
Waiting on opencivicdata/ocd-division-ids#382 |
Merged
|
Redone in #376 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I edited the existing scraper code to account for the changes to site layout and ward names.