-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update division names for Edmonton, CA #381
Update division names for Edmonton, CA #381
Conversation
ocd-division/country:ca/csd:4811061/ward:ipiihkoohkanipiaohtsi,Ipiihkoohkanipiaohtsi | ||
ocd-division/country:ca/csd:4811061/ward:karhiio,Karhiio | ||
ocd-division/country:ca/csd:4811061/ward:metis,Métis | ||
ocd-division/country:ca/csd:4811061/ward:nakota_sga,Nakota Isga |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks to be missing a letter in the id, should be ward:nakota_isga
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I fixed this in the newest commit
@@ -7411,18 +7411,18 @@ ocd-division/country:ca/csd:4811052/ward:8,Ward 8,,,,,,,,,,,,,, | |||
ocd-division/country:ca/csd:4811056,Fort Saskatchewan,,,,,CY,N,Fort Saskatchewan,,City of Fort Saskatchewan,,,,, | |||
ocd-division/country:ca/csd:4811059,Sturgeon County,,,,,MD,Y,Sturgeon County,,Municipality of Sturgeon County,,,,, | |||
ocd-division/country:ca/csd:4811061,Edmonton,,,,,CY,Y,Edmonton,,City of Edmonton,,,,, | |||
ocd-division/country:ca/csd:4811061/ward:1,Ward 1,,,,,,,,,,,,,, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider keeping these and instead adding aliases in aliases.csv instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was looking at the aliases file and seems to be more about federal divisions rather than council wards. @jpmckinney James any thoughts on if these should be shifted into the aliases file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to validFrom/validThrough because the boundaries themselves have changed as well, with no clear mapping: https://edmonton.ctvnews.ca/edmonton-s-new-indigenous-ward-names-explained-1.5599364
I can update the PR.
I couldn't add commits to this PR so I opened #382 |
This PR updates the division names to reflect Edmonton's renaming of its wards