-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ethiopia OCD IDs #239
base: master
Are you sure you want to change the base?
Add Ethiopia OCD IDs #239
Conversation
* Add states * Update README * Update hyperlink * Update level 1 IDs to ISO3166-2 code * Add constituencies * Update constituency source * Update constituency info * Update constituencies layout * Compile states and constituencies * add country name and update Amba district * add parents to electoral districs * update the country file Co-authored-by: 4bic <[email protected]>
* Add states * Update hyperlink * Update level 1 IDs to ISO3166-2 code * Add constituencies * Compile states and constituencies * update the country file * Add parent level to states Co-authored-by: Jean Githae <[email protected]>
Hi @jpmckinney, whenever you can, do review, we'd like to add a few countries we are looking at. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a few comments. I'm assuming the total constituencies matches the official source.
@jloutsenhizer For additional review.
ocd-division/country:et,Ethiopia,, | ||
ocd-division/country:et/administration:aa,Addis Ababa,, | ||
ocd-division/country:et/administration:aa/ed:44075,44075,, | ||
ocd-division/country:et/administration:aa/ed:werda_1_and_9,Werda 1/9,ocd-division/country:et/administration:aa/ed:woreda_1_and_9,Possible spelling change across terms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the alternative spellings necessary? We typically only create "sameAs" entries when renaming an OCD-ID – not when creating it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got you, thank you for that, so something that may need more clarification would be how to capture
instances where a region has multiple versions of the name eg Mekelle / Mekele / Mek'ele
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in this project we just adopt one name. There are many projects, like GeoNames, which track alternative names, but that is not the goal of this project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, this will be cleaned up and updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this is in good shape once state
vs regional_state
is resolved and the sameAs
annotations for the spellings of the electoral districts is cleaned up
The OCD identifiers are created based on the ISO 3166-2 code [(source)](https://en.wikipedia.org/wiki/ISO_3166-2:ET) | ||
|
||
## Constituencies | ||
* Constituencies represented as *ed*, sourced from [hopr.gov.et](http://hopr.gov.et/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a more specific page to link to for the source of the constituencies? The website is down currently so browsing through archive.org is slow, but I'm having trouble finding the correct page.
@@ -0,0 +1,13 @@ | |||
id,name | |||
ocd-division/country:et/state:af,Afar Region |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can you sort this file?
@@ -0,0 +1,653 @@ | |||
id,name,sameAs,sameAsNote | |||
ocd-division/country:et/administration:aa/ed:44075,44075,, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there's too many constituencies. I count 652 in this file, but my understanding is that there's only 547 seats: https://en.wikipedia.org/wiki/House_of_Peoples%27_Representatives
No description provided.