Adding fixes for issues raised by @jpmckinney #71
Conversation
| Value to set for the attribute in the Committee object. | ||
|
|
||
| description | ||
| String containing whatever associated text we got along with the status |
There was a problem hiding this comment.
Change 'status change' to 'attribute change'?
| @@ -268,7 +276,7 @@ id | |||
| Open Civic Data-style id in the format ``ocd-campaignfinance-candidateorientation/{{uuid}}`` | |||
|
|
|||
| candidate | |||
| Candidate | |||
| OCD Person representing the candidate | |||
There was a problem hiding this comment.
Change to 'OCD Person indicating the candidate' to avoid any confusion in the meaning of 'representing', and for consistency with other definitions.
| @@ -23,7 +23,8 @@ Filing | |||
| Any single document filed with a Regulator. | |||
|
|
|||
| Jurisdiction | |||
| The region covered by an Office, or for which an Election is being held. | |||
| OCD Jurisdiction indicating the region covered by an Office, or for which an | |||
There was a problem hiding this comment.
Lowercase 'Office' as Office is not a class.
| Questions to answer | ||
| ------------------- | ||
| * How to model Committee Status and Committee Purpose inside of OCD Organization | ||
| models? | ||
| Just add additional fields for those. Not sure why this was ever a question. |
There was a problem hiding this comment.
We can add a purpose field to Organization, like on W3C ORG, on which Organization is based. Open a new issue for that, and link from the answer to this question?
There was a problem hiding this comment.
Similarly, W3C Registered Organization has a orgStatus field, which we can consider reusing.
| * How to handle different types of Committees beyond just imputing their types | ||
| based on (say) whether they are oriented toward more than one Candidate? | ||
| I don't think this is an issue. |
There was a problem hiding this comment.
Delete the question in that case?
| * How to reconcile multiple reports that describe the same contribution, | ||
| expenditure or other event? | ||
| Same transactions should have same ids. Multiple filings can point to one |
There was a problem hiding this comment.
Can you capitalize ID here and elsewhere?
Closes #68