Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Campaign Finance Filing: "person" <> contributor #72

Closed
jsfenfen opened this issue Feb 14, 2017 · 4 comments
Closed

Campaign Finance Filing: "person" <> contributor #72

jsfenfen opened this issue Feb 14, 2017 · 4 comments

Comments

@jsfenfen
Copy link

I don't think I get the logic of making contributors "persons"--is this an optional designation?

@aepton, @jpmckinney : Consider the case of a committee giving to another committee. Wouldn't that mean the committee is a committee (and hence a subtype of a popolo org) when it is receiving money and other times the committee is a person (and then a subtype of a popolo person) when it is donating? To my nose that doesn't smell right and makes tracking the flow of money harder, not easier.

Moreover, differentiating contributor types is often the point of this sorta work, even if there aren't easy answers available in the source data. Being able to say that XX percent of funds came from corporate donors is pretty powerful... I don't really understand the rules here, but I'd make donor type it's own field, where person and organization are options, but only assigned if there's solid reason for thinking this (in many jurisdictions this info can be gleaned, at least in part, though I'm sure that's not true everywhere). And, of course, detailed local knowledge may be the only way to know for sure...

@aepton
Copy link
Contributor

aepton commented Feb 14, 2017

Yeah, that's a good point. Committee -> Committee breaks the notion of sender == person and recipient == person.

What would be a good entity type here? Post or Organization could conceivably fit, but not without a bit of leakiness in the abstraction.

It could be a Transaction Entity, with optional Person and Organization fields, either of which is filled out depending on what the sender/recipient are.

@jpmckinney
Copy link
Member

I think we can model this similar to how Bill models sponsorships, which allows both people and organizations to sponsor bills.

@aepton
Copy link
Contributor

aepton commented Feb 14, 2017

Fixed.

@jpmckinney
Copy link
Member

Closed by #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants