Drop init argument when not needed in query key #2061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3751ad8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
For urls that do not include an init param, generate a query key of length 2. This allows the value to be passed directly to `invalidateQueries()`. Without this change, the package generates `["get", "/foo", undefined]` which does not correctly match the corresponding get query. Related to openapi-ts#1806
Contributor
|
Looks good to me ! Could you add a minor changeset? |
drwpow
approved these changes
Jan 25, 2025
Contributor
drwpow
left a comment
drwpow
left a comment
There was a problem hiding this comment.
Great test, thank you! If you could add a patch changeset (see comment) I’d be happy to approve & release
✅ Deploy Preview for openapi-ts ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
For urls that do not include an init param, generate a query key of length 2. This allows the value to be passed directly to
invalidateQueries().Without this change, the package generates
["get", "/foo", undefined]which does not correctly match the corresponding get query.Related to #1806
How to Review
This doesn't quite solve the problem when there are init params but at least solves for the case where there are no params...
Checklist
docs/updated (if necessary)pnpm run update:examplesrun (only applicable for openapi-typescript)