Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix :numpy has no attribute 'bool8' #3295

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

bug fix :numpy has no attribute 'bool8' #3295

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba8ef6e
fix numpy has no attribute 'bool8'
nocoding03 Oct 10, 2024
f9a2c9a
fix numpy has no attribute bool8
nocoding03 Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions gym/utils/passive_env_checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,19 +222,19 @@ def env_step_passive_checker(env, action):
)
obs, reward, done, info = result

if not isinstance(done, (bool, np.bool8)):
if not isinstance(done, (bool, np.bool_)):
logger.warn(
f"Expects `done` signal to be a boolean, actual type: {type(done)}"
)
elif len(result) == 5:
obs, reward, terminated, truncated, info = result

# np.bool is actual python bool not np boolean type, therefore bool_ or bool8
if not isinstance(terminated, (bool, np.bool8)):
if not isinstance(terminated, (bool, np.bool_)):
logger.warn(
f"Expects `terminated` signal to be a boolean, actual type: {type(terminated)}"
)
if not isinstance(truncated, (bool, np.bool8)):
if not isinstance(truncated, (bool, np.bool_)):
logger.warn(
f"Expects `truncated` signal to be a boolean, actual type: {type(truncated)}"
)
Expand Down