Fix envpool bug with missing mask key #3026
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a bug when using latest gym (v0.25.1) with envpool. See #3021.
This arises since gym requires
_X
mask key to be present in infos to indicate if elementi
ininfos[X]
exists. But this is not a requirement in envpool. However as mentioned in the issue thread, for truncated, whenterminated=True
, we don't care about the value oftruncated
, therefore we can practically treat the key not existing to be the same as the key existing and being set to False. The compatibility function is changed to reflect this.truncated
is set to False when this occurs, even in list infos (old vector infos api) for consistency. This leads to slight loss of information, but again practically should not affect anything. And this is only through compatibility functions, when using new API exclusively, this problem does not occur,terminated=True
,truncated=True
can occur together as these are independent events.Fixes #3021
Type of change
Please delete options that are not relevant.
Checklist:
pre-commit
checks withpre-commit run --all-files
(seeCONTRIBUTING.md
instructions to set it up)