-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug Report] gym normalize wrappers are incompatible with envpool #3021
Comments
Thank you for the bug report. In the step API compatibility code, I assumed that if But envpool does not seem to use mask keys. I have a question in that case. In the old step API there is a difference in meaning when the key |
I think I can patch this up regardless, but do we want to unify the way envpool handles vector infos vs how gym handles it? @pseudo-rnd-thoughts |
The reason gym changed its approach to vector info is for jax based vectorisation, in particular, for brax, the shape of each key needed to be constant. However, it is impossible to tell between default data and no data if you want to use default data.
Therefore, we added an underscore version of each key to show if the key actually exists for the sub-env such that default data is usable. I hope that makes sense. For |
Describe the bug
gym.wrappers.NormalizeObservation
andgym.wrappers.NormalizeReward
are incompatible with envpool. See sail-sg/envpool#185Code example
System Info
Describe the characteristic of your environment:
Additional context
Add any other context about the problem here.
Checklist
The text was updated successfully, but these errors were encountered: