-
Notifications
You must be signed in to change notification settings - Fork 8.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix video recording. #2139
Fix video recording. #2139
Conversation
Thank you ! Fixes it for me too, tested with this : import gym
env = gym.make('CartPole-v0')
env = gym.wrappers.Monitor(env, "recording", force=True)
env.reset()
while True:
obs, rew, done, info = env.step(env.action_space.sample())
if done:
break |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I stumbled on this problem by chance, and almost submitted the exact same bug fix. Approve!
I already fix the code but still have same problem(262bytes), can I ask why? |
Oh! I see, if you change the code, you need reboot your PC to activate the change. I reboot and succeed! |
Why is this not released yet? |
Tested with
python examples/agents/random_agent.py
. The code before the change would create empty video files.