Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix video recording. #2139

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Fix video recording. #2139

merged 1 commit into from
Jan 11, 2021

Conversation

mahiuchun
Copy link
Contributor

Tested with python examples/agents/random_agent.py. The code before the change would create empty video files.

@khazit
Copy link

khazit commented Dec 27, 2020

Thank you ! Fixes it for me too, tested with this :

import gym
env = gym.make('CartPole-v0')
env = gym.wrappers.Monitor(env, "recording", force=True)
env.reset()
while True:
    obs, rew, done, info = env.step(env.action_space.sample())
    if done:
        break

Copy link

@feiden feiden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stumbled on this problem by chance, and almost submitted the exact same bug fix. Approve!

@CrazyNicolas
Copy link

I already fix the code but still have same problem(262bytes), can I ask why?

@CrazyNicolas
Copy link

I already fix the code but still have same problem(262bytes), can I ask why?

Oh! I see, if you change the code, you need reboot your PC to activate the change. I reboot and succeed!

@manuel-delverme
Copy link

Why is this not released yet?

zlig pushed a commit to zlig/gym that referenced this pull request Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants