-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support vectorized video rendering #61
Conversation
You can run tests locally with:
|
And I agree it would be a cool feature, just hasn't been a priority to implement. I'm really glad you are doing this! |
Hi, so when I try to run the example code on top of your fork, it runs and gives out a bunch of .mp4 files, but when I try to play these files in a video player, I get an error message "this file is not playable". The files are also super small at 1kb. Do you happen to know what is going wrong? |
"a bunch of .mp4 file" was due to the |
Weird. Well, the example is generating videos now, so one way or another, it seems to be working. There are still a couple of things that are a little broken. In particular, calling Again, thanks for the contribution. Rendering in vector environments was something we were definitely missing. |
It was my pleasure. I just pushed a fix for the |
Looks good! I'm happy to see this merged. @justinkterry |
Hello, this PR enables the video recording through
VecVideoRecorder
from sb3. Below is an example code:It will be great to incorporate this code. Being selfish for a second, this change will help me record the videos of agents playing the game throughout training, much like my experiments with the procgen env. https://wandb.ai/cleanrl/cleanrl.benchmark/reports/Procgen-New--Vmlldzo0NDUyMTg