-
Notifications
You must be signed in to change notification settings - Fork 202
Codex/update node.js verification in verify.sh #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
drtraderai-glitch
wants to merge
11
commits into
openai:main
Choose a base branch
from
drtraderai-glitch:codex/update-node.js-verification-in-verify.sh
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
6db7452
Fix nvm usage in verification script
drtraderai-glitch fea00c8
Merge pull request #1 from drtraderai-glitch/codex/update-verify.sh-f…
drtraderai-glitch fe853c3
Fix NVM usage in verify script
drtraderai-glitch e1c84c7
Guard nvm default alias detection
drtraderai-glitch 9954014
Merge pull request #3 from drtraderai-glitch/codex/fix-high-priority-…
drtraderai-glitch e89e1c2
Guard default nvm alias lookup in verify script
drtraderai-glitch 51a3f6a
Merge pull request #5 from drtraderai-glitch/codex/fix-verify-script-…
drtraderai-glitch 60b66dd
Guard missing nvm default alias
drtraderai-glitch 45f46f8
Merge pull request #6 from drtraderai-glitch/codex/fix-verify-script-…
drtraderai-glitch c6e6275
Guard nvm default alias capture
drtraderai-glitch d6959e5
Merge pull request #7 from drtraderai-glitch/codex/fix-high-priority-…
drtraderai-glitch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new Node block executes
nvm alias --no-colors default, but--no-colorsin this position is treated as the alias name, so this call actually creates/updates an alias called--no-colorsand returnsdefaultas its value.original_nvm_defaulttherefore becomes the literal stringdefault, and the later restore step callsnvm alias default default, leaving the default alias pointing to itself and breakingnvm use defaultfor the user until they manually reset it. The script can also terminate early if that restore command fails underset -e. This regression occurs whenever the script runs in an environment with nvm.Useful? React with 👍 / 👎.