Codex/update node.js verification in verify.sh #96
Conversation
…or-node-loop Fix nvm usage in verification script
…bug-in-verify-script Fix verify script NVM usage and restore default alias
…nvm-usage-issues Handle missing default nvm alias in verify script
…nvm-usage-issues-7pic58 Handle missing default NVM alias in verify script
…bug-in-verify.sh Handle missing nvm default alias when capturing original value
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| nvm_alias_default_output="$(nvm alias --no-colors default 2>/dev/null || true)" | ||
| if [ -n "${nvm_alias_default_output}" ]; then | ||
| parsed_nvm_default="$(printf '%s\n' "${nvm_alias_default_output}" | head -n 1 | awk '{print $3}')" |
There was a problem hiding this comment.
The new Node block executes nvm alias --no-colors default, but --no-colors in this position is treated as the alias name, so this call actually creates/updates an alias called --no-colors and returns default as its value. original_nvm_default therefore becomes the literal string default, and the later restore step calls nvm alias default default, leaving the default alias pointing to itself and breaking nvm use default for the user until they manually reset it. The script can also terminate early if that restore command fails under set -e. This regression occurs whenever the script runs in an environment with nvm.
Useful? React with 👍 / 👎.
1 participant
No description provided.