Girazoki fix index in transfer multicurrencies #696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlc
approved these changes
Feb 15, 2022
shaunxw
approved these changes
Feb 15, 2022
girazoki
added a commit
to moonbeam-foundation/open-runtime-module-library
that referenced
this pull request
Feb 16, 2022
* Fix index for fee in transfer_multi_currencies * Add removed event from the last refactor * Fix event * Fix event
syan095
pushed a commit
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets the fee item before the multicurrencies vec is converted to a MultiAssets item. The reason is that in the conversion to MultiAssets, the vector is sorted and the index might no longer match what the users specifies.
It also adds a removed event from last refactor