Fix unit for hw.network.bandwidth.limit metric #91
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit for `hw.network.bandwidth.limit` must be `By/s`
|
@jsuereth Link check failed because there are broken link in another Markdown file (links to IBM documentation). |
arminru
changed the title
arminru
approved these changes
Jun 7, 2023
@bertysentry This should be fixed now with #92 |
joaopgrassi
reviewed
Jun 9, 2023
joaopgrassi
approved these changes
Jun 29, 2023
|
Ping @open-telemetry/specs-semconv-approvers @open-telemetry/specs-semconv-maintainers. This should be good to merge, I will left it open for a day then will merge if no one has any objections. |
|
lol, is this going to be ever merged? 😅 |
|
Thank you @reyang 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit for
hw.network.bandwidth.limitmust beBy/sFixes #97.