Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units for hw.network.bandwidth.limit metric #97

Closed
sebastien-rosset opened this issue Jun 1, 2023 · 4 comments · Fixed by #91
Closed

Units for hw.network.bandwidth.limit metric #97

sebastien-rosset opened this issue Jun 1, 2023 · 4 comments · Fixed by #91
Assignees

Comments

@sebastien-rosset
Copy link
Contributor

What are you trying to achieve?

In the hw.network instrument, the hw.network.bandwidth.limit metric is defined as:

  • Description: Link speed
  • Units: By
  • Data point type: UpDownCounter

The units are currently set to "By" (bytes), which is independent of time. However, the bandwidth is the capacity of a link to transmit/receive data, expressed as a quantity of information (e.g., bits or bytes) per unit of time (e.g. second).

What did you expect to see?

I was expecting units for the hw.network.bandwidth.limit metric to be something like By/s.

Additional context.

Add any other context about the problem here. If you followed an existing documentation, please share the link to it.

@arminru
Copy link
Member

arminru commented Jun 6, 2023

cc @bertysentry

@bertysentry
Copy link
Contributor

Thank you for reporting this issue, it's a mistake. If possible, please move this issue to the semantic-conventions repository, which hosts semantic conventions from now on.

I fixed it with this proposed PR

@sebastien-rosset
Copy link
Contributor Author

Thank you for the fix! It looks like I don't have the permission to transfer the issue.

@arminru arminru transferred this issue from open-telemetry/opentelemetry-specification Jun 7, 2023
@arminru
Copy link
Member

arminru commented Jun 7, 2023

Thank you for the fix! It looks like I don't have the permission to transfer the issue.

I moved it now 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants