Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .chloggen/3753.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
change_type: enhancement
component: db
note: Promote Oracle Database connection attributes to release candidate so the
RC `db.oracledb.client` span does not reference lower-stability attributes.
issues: [3753]
10 changes: 5 additions & 5 deletions docs/db/oracledb.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,11 @@ Spans representing calls to a Oracle SQL Database adhere to the general [Semanti
| [`db.query.summary`](/docs/registry/attributes/db.md) | ![Stable](https://img.shields.io/badge/-stable-lightgreen) | `Recommended` [11] | string | Low cardinality summary of a database query. [12] | `SELECT wuser_table`; `INSERT shipping_details SELECT orders`; `get user by id` |
| [`db.query.text`](/docs/registry/attributes/db.md) | ![Stable](https://img.shields.io/badge/-stable-lightgreen) | `Recommended` [13] | string | The database query being executed. [14] | `SELECT * FROM wuser_table where username = :mykey` |
| [`db.stored_procedure.name`](/docs/registry/attributes/db.md) | ![Stable](https://img.shields.io/badge/-stable-lightgreen) | `Recommended` [15] | string | The name of a stored procedure within the database. [16] | `GetCustomer` |
| [`oracle.db.domain`](/docs/registry/attributes/oracledb.md) | ![Development](https://img.shields.io/badge/-development-blue) | `Recommended` | string | The database domain associated with the connection. [17] | `example.com`; `corp.internal`; `prod.db.local` |
| [`oracle.db.instance.name`](/docs/registry/attributes/oracledb.md) | ![Development](https://img.shields.io/badge/-development-blue) | `Recommended` | string | The instance name associated with the connection in an Oracle Real Application Clusters environment. [18] | `ORCL1`; `ORCL2`; `ORCL3` |
| [`oracle.db.name`](/docs/registry/attributes/oracledb.md) | ![Development](https://img.shields.io/badge/-development-blue) | `Recommended` | string | The database name associated with the connection. [19] | `ORCL1`; `FREE` |
| [`oracle.db.pdb`](/docs/registry/attributes/oracledb.md) | ![Development](https://img.shields.io/badge/-development-blue) | `Recommended` | string | The pluggable database (PDB) name associated with the connection. [20] | `PDB1`; `FREEPDB` |
| [`oracle.db.service`](/docs/registry/attributes/oracledb.md) | ![Development](https://img.shields.io/badge/-development-blue) | `Recommended` | string | The service name currently associated with the database connection. [21] | `order-processing-service`; `db_low.adb.oraclecloud.com`; `db_high.adb.oraclecloud.com` |
| [`oracle.db.domain`](/docs/registry/attributes/oracledb.md) | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) | `Recommended` | string | The database domain associated with the connection. [17] | `example.com`; `corp.internal`; `prod.db.local` |
| [`oracle.db.instance.name`](/docs/registry/attributes/oracledb.md) | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) | `Recommended` | string | The instance name associated with the connection in an Oracle Real Application Clusters environment. [18] | `ORCL1`; `ORCL2`; `ORCL3` |
| [`oracle.db.name`](/docs/registry/attributes/oracledb.md) | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) | `Recommended` | string | The database name associated with the connection. [19] | `ORCL1`; `FREE` |
| [`oracle.db.pdb`](/docs/registry/attributes/oracledb.md) | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) | `Recommended` | string | The pluggable database (PDB) name associated with the connection. [20] | `PDB1`; `FREEPDB` |
| [`oracle.db.service`](/docs/registry/attributes/oracledb.md) | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) | `Recommended` | string | The service name currently associated with the database connection. [21] | `order-processing-service`; `db_low.adb.oraclecloud.com`; `db_high.adb.oraclecloud.com` |
| [`server.address`](/docs/registry/attributes/server.md) | ![Stable](https://img.shields.io/badge/-stable-lightgreen) | `Recommended` | string | Name of the database host. [22] | `example.com`; `10.1.2.80`; `/tmp/my.sock` |
| [`db.query.parameter.<key>`](/docs/registry/attributes/db.md) | ![Development](https://img.shields.io/badge/-development-blue) | `Opt-In` | string | A database query parameter, with `<key>` being the parameter name, and the attribute value being a string representation of the parameter value. [23] | `someval`; `55` |
| [`db.response.returned_rows`](/docs/registry/attributes/db.md) | ![Development](https://img.shields.io/badge/-development-blue) | `Opt-In` | int | Number of rows returned by the operation. [24] | `10`; `30`; `1000` |
Expand Down
10 changes: 5 additions & 5 deletions docs/registry/attributes/oracledb.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ This section defines attributes for Oracle Database.

| Key | Stability | Value Type | Description | Example Values |
| --- | --- | --- | --- | --- |
| <a id="oracle-db-domain" href="#oracle-db-domain">`oracle.db.domain`</a> | ![Development](https://img.shields.io/badge/-development-blue) | string | The database domain associated with the connection. [1] | `example.com`; `corp.internal`; `prod.db.local` |
| <a id="oracle-db-instance-name" href="#oracle-db-instance-name">`oracle.db.instance.name`</a> | ![Development](https://img.shields.io/badge/-development-blue) | string | The instance name associated with the connection in an Oracle Real Application Clusters environment. [2] | `ORCL1`; `ORCL2`; `ORCL3` |
| <a id="oracle-db-name" href="#oracle-db-name">`oracle.db.name`</a> | ![Development](https://img.shields.io/badge/-development-blue) | string | The database name associated with the connection. [3] | `ORCL1`; `FREE` |
| <a id="oracle-db-pdb" href="#oracle-db-pdb">`oracle.db.pdb`</a> | ![Development](https://img.shields.io/badge/-development-blue) | string | The pluggable database (PDB) name associated with the connection. [4] | `PDB1`; `FREEPDB` |
| <a id="oracle-db-service" href="#oracle-db-service">`oracle.db.service`</a> | ![Development](https://img.shields.io/badge/-development-blue) | string | The service name currently associated with the database connection. [5] | `order-processing-service`; `db_low.adb.oraclecloud.com`; `db_high.adb.oraclecloud.com` |
| <a id="oracle-db-domain" href="#oracle-db-domain">`oracle.db.domain`</a> | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) | string | The database domain associated with the connection. [1] | `example.com`; `corp.internal`; `prod.db.local` |
| <a id="oracle-db-instance-name" href="#oracle-db-instance-name">`oracle.db.instance.name`</a> | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) | string | The instance name associated with the connection in an Oracle Real Application Clusters environment. [2] | `ORCL1`; `ORCL2`; `ORCL3` |
| <a id="oracle-db-name" href="#oracle-db-name">`oracle.db.name`</a> | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) | string | The database name associated with the connection. [3] | `ORCL1`; `FREE` |
| <a id="oracle-db-pdb" href="#oracle-db-pdb">`oracle.db.pdb`</a> | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) | string | The pluggable database (PDB) name associated with the connection. [4] | `PDB1`; `FREEPDB` |
| <a id="oracle-db-service" href="#oracle-db-service">`oracle.db.service`</a> | ![Release Candidate](https://img.shields.io/badge/-rc-mediumorchid) | string | The service name currently associated with the database connection. [5] | `order-processing-service`; `db_low.adb.oraclecloud.com`; `db_high.adb.oraclecloud.com` |

**[1] `oracle.db.domain`:** This attribute SHOULD be set to the value of the `DB_DOMAIN` initialization parameter,
as exposed in `v$parameter`. `DB_DOMAIN` defines the domain portion of the global
Expand Down
10 changes: 5 additions & 5 deletions model/oracledb/registry.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ groups:
attributes:
- id: oracle.db.name
type: string
stability: development
stability: release_candidate
brief: >
The database name associated with the connection.
note: |
This attribute SHOULD be set to the value of the parameter `DB_NAME` exposed in `v$parameter`.
examples: ["ORCL1", "FREE"]
- id: oracle.db.domain
type: string
stability: development
stability: release_candidate
brief: >
The database domain associated with the connection.
note: |
Expand All @@ -28,7 +28,7 @@ groups:
examples: ["example.com", "corp.internal", "prod.db.local"]
- id: oracle.db.instance.name
type: string
stability: development
stability: release_candidate
brief: >
The instance name associated with the connection in an Oracle Real Application Clusters environment.
note: |
Expand All @@ -38,7 +38,7 @@ groups:
examples: ["ORCL1", "ORCL2", "ORCL3"]
- id: oracle.db.pdb
type: string
stability: development
stability: release_candidate
brief: >
The pluggable database (PDB) name associated with the connection.
note: |
Expand All @@ -49,7 +49,7 @@ groups:
examples: ["PDB1", "FREEPDB"]
- id: oracle.db.service
type: string
stability: development
stability: release_candidate
brief: >
The service name currently associated with the database connection.
note: |
Expand Down
2 changes: 0 additions & 2 deletions policies/group_stability.rego
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ deny contains group_stability_violation(description, group.id, name) if {
"entity.service",
# TODO: https://github.com/open-telemetry/semantic-conventions/issues/1616
"metric.dotnet.process.cpu.time",
# TODO: https://github.com/open-telemetry/semantic-conventions/issues/3753
"span.db.oracledb.client",
}
not exceptions[group.id]

Expand Down
Loading