Skip to content

[db/oracledb] Promote Oracle DB connection attributes to RC#3795

Merged
lmolkova merged 4 commits into
open-telemetry:mainfrom
sudarshan12s:issue3735
Jun 22, 2026
Merged

[db/oracledb] Promote Oracle DB connection attributes to RC#3795
lmolkova merged 4 commits into
open-telemetry:mainfrom
sudarshan12s:issue3735

Conversation

@sudarshan12s

@sudarshan12s sudarshan12s commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Fixes #3753

Changes

This PR promotes the Oracle DB connection attributes referenced by span.db.oracledb.client from development to release_candidate.

db.oracledb.client is already marked as RC, but it referenced these lower-stability attributes:

oracle.db.domain
oracle.db.instance.name
oracle.db.name
oracle.db.pdb
oracle.db.service

Per the change introduced in #3752, a group should not reference attributes with lower stability than the group itself unless those attributes are opt_in. These Oracle DB attributes are referenced as Recommended, so they need to be promoted to RC.

The issue was mentioned here

Important

Pull request acceptance is subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above may be automatically rejected and closed.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Links to prototypes or existing instrumentations (when adding or changing conventions)
  • Disclose AI usage, see OTel GenAI policy:
    • no AI used
    • AI-assisted
    • bulk AI-generated
  • I have the experience and knowledge necessary to understand, review, and validate all content in this PR.1

Footnotes

  1. Yes, I can answer maintainer questions about the content of this PR without using AI.

@github-actions

Copy link
Copy Markdown

👋 Thanks for your contribution!

This PR modifies file(s) in area(s) that do not currently have an active SIG/project:

  • oracledb

Per the area ownership process,
changes to these areas need an active SIG/project, so this PR has been automatically
closed and labeled triage:rejected:declined.

This does not mean your change is unwelcome:

  • For substantial changes or new conventions: Consider starting a new SIG/project.
    See the Project Management guide.
  • If you believe this was closed in error: Please reach out in the
    #otel-semantic-conventions channel on the CNCF Slack.

Thanks again for taking the time to contribute! 🙏

@github-actions github-actions Bot closed this Jun 14, 2026
@sudarshan12s

Copy link
Copy Markdown
Contributor Author

CC @open-telemetry/semconv-db-approvers , Can this PR be triaged.

Thanks

@joaopgrassi

Copy link
Copy Markdown
Member

Re-opening so the db approvers can take a look.

@joaopgrassi joaopgrassi reopened this Jun 16, 2026
@joaopgrassi joaopgrassi moved this from Untriaged to Awaiting codeowners approval in Semantic Conventions Triage Jun 18, 2026

@lmolkova lmolkova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment thread .chloggen/3753.yaml Outdated
Comment thread .chloggen/3753.yaml Outdated
@lmolkova lmolkova moved this from Awaiting codeowners approval to Ready to be Merged in Semantic Conventions Triage Jun 19, 2026
@lmolkova lmolkova moved this from Ready to be Merged to Needs More Approval in Semantic Conventions Triage Jun 19, 2026
@sudarshan12s
sudarshan12s requested a review from a team as a code owner June 20, 2026 06:03
@kamphaus kamphaus moved this from Needs More Approval to Ready to be Merged in Semantic Conventions Triage Jun 20, 2026
@lmolkova
lmolkova added this pull request to the merge queue Jun 22, 2026
Merged via the queue into open-telemetry:main with commit 5f7de49 Jun 22, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

db.oracledb.client span is marked as RC but it uses attributes with dev stability

4 participants