Promote a selection of k8s and container attributes to beta#3304
Promote a selection of k8s and container attributes to beta#3304jsuereth merged 1 commit intoopen-telemetry:mainfrom
Conversation
thompson-tomo
left a comment
There was a problem hiding this comment.
Note mediumpink is not a named web color https://www.w3schools.com/colors/colors_names.asp hence docs are using the default aka green. I would change it to lightpink and then re-generate docs.
|
@open-telemetry/semconv-k8s-approvers PTAL |
|
@ChrsMark something looks wrong with the commit ids, the diff for the check fails. Maybe a rebase fixes it. |
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
ca6ce39 to
141986d
Compare
|
@joaopgrassi thank's for the heads-up, should be good now |
|
before merging, I'd like to discuss since we haven't used beta in semconv previously
|
|
While reviewing, I re-read https://opentelemetry.io/docs/specs/otel/document-status/. To me moving to Alpha sounds like the natural path. If now the sig believes that there's high confidence in the current design, meaning no new features/breaking changes, then I guess moving directly to RC makes sense. |
The idea is to go through the stability levels described at https://opentelemetry.io/docs/specs/semconv/general/semantic-convention-groups/#group-stability before graduating as The ultimate goal (of the K8s SIG in alignment with the Collector SIG as per #3119) is to transition the Since we have lot's of work ahead I would advertise this change with a blogpost once we have these semantic conventions in I would target for the Let me know what you think @trask @joaopgrassi. |
|
@open-telemetry/specs-semconv-approvers let us know if there is anything missing here |
jsuereth
left a comment
There was a problem hiding this comment.
Should this also be moving the entities to beta?
|
@ChrsMark thanks, sounds like a good plan 👍 |
Entities have not been included since they are not introduced yet in So @jsuereth I think entities can wait unless we have a specific need for this? |
|
I think it makes sense to promote the attribute names separately from the entities as a whole at this point. It’s important to provide more assurance to users that we’re not planning to change the names themselves in the future even as part of the entity work. I believe many systems rely on these naming conventions already. |
|
I'm just trying to make sure we have a consistent policy around stabilization here with attributes, entities + signals. I'm fine stabilizing attributes then revisiting stabilization for entities. |
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Bumping version of semconv to 1.40 Release: https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.40.0 In particular open-telemetry/semantic-conventions#3304 moves the used attributes to `beta`. --------- Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
…etry#46644) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Bumping version of semconv to 1.40 Release: https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.40.0 In particular open-telemetry/semantic-conventions#3304 moves the used attributes to `beta`. --------- Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
…etry#46644) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Bumping version of semconv to 1.40 Release: https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.40.0 In particular open-telemetry/semantic-conventions#3304 moves the used attributes to `beta`. --------- Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Changes
Similar to #3215.
This is part of #3120. The purpose of this PR is to again advertise the intention towards having those attributes as Release Candidates soon.
open-telemetry/opentelemetry-collector-contrib#45447 aims to use the
alphaversion in the Collector Contrib already.All suggested attributes are already in use from several Collector components as described at #3120 (comment):
Closes #3381
Important
Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.
Merge requirement checklist
[chore]