[k8s] Fix updowncounters to follow the non-pluralization rule#2822
[k8s] Fix updowncounters to follow the non-pluralization rule#2822jsuereth merged 5 commits intoopen-telemetry:mainfrom
Conversation
1761c7e to
1dc71dc
Compare
1dc71dc to
7a3898b
Compare
f2ec37b to
6b81fd4
Compare
|
Even after #2306 is resolved, it still unclear why is this change required. Looking at these guidelines it seems like existing naming still valid.
What am I missing? |
|
The PR introduces a significant number of breaking changes, and I’m not sure the current justification is sufficient. |
|
@dmitryax the guidance moves us towards consistency based on the discussions happened in the respective guidance PR and specifically #2317 (comment). The part that applies here is that Also note that those metrics are not in use yet in the Collector in the current format hence it's not really an impactful breaking change. Those metrics are already different to the Collector's ones as we can see in https://github.com/open-telemetry/semantic-conventions/pull/2822/files#diff-ba5fa96c108eca125c2c88f68cdfb0a3d0c95792912f5518eedd55666bc1c033. I don't have a strong preference for this change either but it seems that we need it so as to be consistent with the rest of the project. @lmolkova please chime in if we miss anything here. |
|
Ok, but the guidelines in the spec are still not strong enough for this change. All of the existing metrics seem to follow this section:
Do we need to remove that part from the spec? In general, looking at the changed metrics names as a user, the existing ones seem to be more intuitive than to the new ones. |
|
I will update this based on the outcome of #2822 (comment). |
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Co-authored-by: David Ashpole <dashpole@google.com>
03d620f to
5fb40ce
Compare
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
|
@open-telemetry/semconv-k8s-approvers please take another look since this PR has been updated. @open-telemetry/specs-semconv-maintainers could you help with the deprecation question from #2822 (comment)? Right now the checks fail because of the "double" deprecation chain, or do I miss anything else there? |
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Fixes #2301
Changes
This brings names in alignment with the pluralisation guidelines: https://github.com/open-telemetry/semantic-conventions/blob/v1.37.0/docs/general/naming.md#do-not-pluralize-updowncounter-names
Renamed metrics:
Merge requirement checklist
[chore]