[chore] Clarify .count for updowncounters guidance#2317
[chore] Clarify .count for updowncounters guidance#2317lmolkova merged 4 commits intoopen-telemetry:mainfrom
Conversation
eccc9c6 to
1655619
Compare
trask
left a comment
There was a problem hiding this comment.
I've added this to Mon SIG meeting agenda just to confirm with more folks, thanks
Dismissing as we seem to have a bigger problem, @lmolkova found. Let's see what we can come up to improve this.
|
@lmolkova @joaopgrassi @trask, should we then keep the guidance and make it more explicit with sth like |
|
@ChrsMark we have a bunch of metrics that use - Use count instead of pluralization for UpDownCounters
+ Do not pluralize UpDownCounter nameswith some examples using |
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
696478b to
1ffe3c9
Compare
Ok, I'm fine with that. I updated the PR accordingly. If there are suggestions about the wording or more examples to add let me know. |
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
|
Thank's @lmolkova , your comments should be addressed now, please take another look. |
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Fixes #2306
Changes
This PR tries to clarfiy the guidance regarding the usage of
.countforUpDownCounters as it was described at #2306./cc @trask @lmolkova @braydonk
Merge requirement checklist
[chore]