Skip to content

[chore] Consolidate genai.request.seed for openai#1715

Merged
joaopgrassi merged 2 commits intoopen-telemetry:mainfrom
gyliu513:seed
Jan 3, 2025
Merged

[chore] Consolidate genai.request.seed for openai#1715
joaopgrassi merged 2 commits intoopen-telemetry:mainfrom
gyliu513:seed

Conversation

@gyliu513
Copy link
Copy Markdown
Member

Fixes #

This is a follow up for #1710 and #1683

/cc @lmolkova @lzchen @xrmx

Changes

Please provide a brief description of the changes here.

Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.

Merge requirement checklist

@gyliu513 gyliu513 requested review from a team as code owners December 27, 2024 20:49
Signed-off-by: Guangya Liu <gyliu@ibm.com>
Comment thread model/gen-ai/spans.yaml
Copy link
Copy Markdown
Member

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thanks!

@joaopgrassi joaopgrassi merged commit 6bc19ef into open-telemetry:main Jan 3, 2025
@gyliu513 gyliu513 deleted the seed branch January 3, 2025 16:28
@xrmx
Copy link
Copy Markdown
Contributor

xrmx commented Jan 7, 2025

Thanks for fixing that @gyliu513

lmolkova pushed a commit to lmolkova/semantic-conventions that referenced this pull request Jan 21, 2025
Signed-off-by: Guangya Liu <gyliu@ibm.com>
Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants