[chore] Consolidate genai.request.seed#1683
[chore] Consolidate genai.request.seed#1683gyliu513 wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
|
It is weird, I can see the dead link can actually be accessed https://web.archive.org/web/20180321091318/http://www.onlamp.com/pub/a/linux/2000/11/16/LinuxAdmin.html |
|
@gyliu513 thanks for the contribution! The markdown tables are auto-generated from yaml definitions - please check https://github.com/open-telemetry/semantic-conventions/blob/main/CONTRIBUTING.md#1-modify-the-yaml-model for more details. Also, we don't remove attributes, we deprecate them - you can find some examples in the https://github.com/open-telemetry/semantic-conventions/blob/main/model/gen-ai/deprecated/registry-deprecated.yaml We'll also need a changelog record for it - you can find more details on how to create one in https://github.com/open-telemetry/semantic-conventions/blob/main/CONTRIBUTING.md#4-changelog. |
ea39a9b to
86bbc5b
Compare
lmolkova
left a comment
There was a problem hiding this comment.
Thanks!
Left a few minor comments.
Please also update the https://github.com/open-telemetry/semantic-conventions/blob/main/schema-next.yaml - add the following under version 1.29.0
# https://github.com/open-telemetry/semantic-conventions/pull/1683
- rename_attributes:
attribute_map:
gen_ai.openai.request.seed: gen_ai.request.seedSigned-off-by: Guangya Liu <gyliu@ibm.com>
lzchen
left a comment
There was a problem hiding this comment.
Awesome, thanks for this!
Fixes #
This is a follow up for https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3081/files#r1884746832
/cc @lmolkova @lzchen
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]