[chore] Update vertex_ai to vertex.ai #1684
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Use this changelog template to create an entry for release notes. | ||
| # | ||
| # If your change doesn't affect end users you should instead start | ||
| # your pull request title with [chore] or use the "Skip Changelog" label. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: deprecation | ||
|
|
||
| # The name of the area of concern in the attributes-registry, (e.g. http, cloud, db) | ||
| component: gen_ai | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Update vertex_ai to vertex.ai | ||
|
|
||
| # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
| # The values here must be integers. | ||
| issues: [1684] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,9 +13,9 @@ groups: | |
| stability: experimental | ||
| value: "openai" | ||
| brief: 'OpenAI' | ||
| - id: vertex.ai | ||
| stability: experimental | ||
| value: "vertex.ai" | ||
|
Member
There was a problem hiding this comment. I can't find any evidence of just "Vertex" without "AI" in GCP's docs, so If that reasoning holds water to keep it as
Member
There was a problem hiding this comment. I also believe we should not change this to be a namespace. Vertex AI seems to be the product name.
Member
There was a problem hiding this comment. OK I re-read and thought about it, giving this is only changing the enum value all if fine.
Member
There was a problem hiding this comment. While we're here, should we prefix with
Member
Author
There was a problem hiding this comment. +1, we can name it as
Member
There was a problem hiding this comment. we're really inconsistent in semconv on prefixing things with cloud name (not intentionally). General issue - #608 E.g. we have Both So what should we do:
Speaking from Azure side, we're likely to stay where we are: cc @jsuereth if he has any thoughts
Member
There was a problem hiding this comment. There's also the
Member
There was a problem hiding this comment. I'm like 80% confident we can rename
Member
Author
There was a problem hiding this comment. based on comments at #1719, seems we need to stick to
Member
There was a problem hiding this comment. I'd leave things as they are for now. We need a consistent strategy across all semconv (we have |
||
| brief: 'Vertex AI' | ||
| - id: gemini | ||
| stability: experimental | ||
|
|
@@ -61,6 +61,11 @@ groups: | |
| stability: experimental | ||
| value: "groq" | ||
| brief: 'Groq' | ||
| - id: vertex_ai | ||
| stability: experimental | ||
| value: "vertex_ai" | ||
| brief: 'Deprecated. Use `vertex.ai` instead.' | ||
| deprecated: "Replaced by `vertex.ai`." | ||
|
|
||
| brief: The Generative AI product as identified by the client or server instrumentation. | ||
| note: | | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lmolkova do you know if we can also need to mark
vertex_aias deprecated? if so, how to make it? This is a value and not an attribute, did not find any example for this, thanks!