Skip to content

Adds mistral_ai as a gen_ai.system attribute value#1719

Merged
joaopgrassi merged 5 commits intoopen-telemetry:mainfrom
codefromthecrypt:mistralai
Jan 9, 2025
Merged

Adds mistral_ai as a gen_ai.system attribute value#1719
joaopgrassi merged 5 commits intoopen-telemetry:mainfrom
codefromthecrypt:mistralai

Conversation

@codefromthecrypt
Copy link
Copy Markdown
Contributor

@codefromthecrypt codefromthecrypt commented Jan 3, 2025

This extends GenAI System to include Mistral AI. This accessed either via its native 'mistralai' API or via OpenAI libraries.

This is a follow-up to #1655

Changes

Added the following:

  • "mistral_ai", not "mistralai" to adhere to conventions suggested by @trask and @lmolkova

Merge requirement checklist

Signed-off-by: Adrian Cole <adrian.cole@elastic.co>
Copy link
Copy Markdown
Member

@drewby drewby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition looks good to me.

Comment thread model/gen-ai/registry.yaml Outdated
@lmolkova lmolkova enabled auto-merge (squash) January 8, 2025 02:32
@trask trask disabled auto-merge January 8, 2025 03:02
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
@codefromthecrypt codefromthecrypt changed the title Adds mistralai as a gen_ai.system attribute value Adds mistral_ai as a gen_ai.system attribute value Jan 8, 2025
Signed-off-by: Adrian Cole <adrian.cole@elastic.co>
@joaopgrassi joaopgrassi merged commit 65f3f8f into open-telemetry:main Jan 9, 2025
@codefromthecrypt codefromthecrypt deleted the mistralai branch January 18, 2025 17:15
lmolkova pushed a commit to lmolkova/semantic-conventions that referenced this pull request Jan 21, 2025
…y#1719)

Signed-off-by: Adrian Cole <adrian.cole@elastic.co>
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Co-authored-by: Joao Grassi <5938087+joaopgrassi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants