Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic Conventions for MongoDB #709

Closed
toumorokoshi opened this issue Nov 10, 2020 · 4 comments
Closed

Semantic Conventions for MongoDB #709

toumorokoshi opened this issue Nov 10, 2020 · 4 comments
Assignees

Comments

@toumorokoshi
Copy link
Member

What are you trying to achieve?

Reach a conclusion on what fields to expose for MongoDB, on top of the existing ones.

Standardizing on the right keys would be great, but I don't have a specific proposal in mind. Just raising the thread in case anyone has a perspective.

Additional context.

Here's a couple examples of Mongo instrumentation:

@toumorokoshi
Copy link
Member Author

One interesting attribute is duration_micros: the duration the query took to actually execute.

I was originally thinking this may not be a good attribute to add, but there are edge cases that are worth being able to detect like significant time spent in the deserialization of the payload, rather than in the query itself.

@Oberon00
Copy link
Member

Oberon00 commented Nov 10, 2020

One interesting attribute is duration_micros: the duration the query took to actually execute.

That might even make sense as a generic span semantic convention like

span.child_time: Use this attribute when this span represents a call into (potentially) uninstrumented code that reports back how long it took to perform the requested operation. Set it to the operation's reported duration in nanoseconds.

Or we might want an event semantic convention for that.

@toumorokoshi
Copy link
Member Author

toumorokoshi commented Nov 12, 2020

I think a generic semantic convention makes a lot of sense, and maybe we can add examples in each semantic convention on the use case (e.g. db query time for the db calls).

I'll send a PR to continue the conversation?

@jack-berg jack-berg transferred this issue from open-telemetry/opentelemetry-specification Feb 7, 2024
@trask
Copy link
Member

trask commented Feb 8, 2024

I believe this can be closed, as this is very old and we have both generic database semantic conventions and mongodb semantic conventions now

@trask trask closed this as completed Feb 8, 2024
joaopgrassi pushed a commit to dynatrace-oss-contrib/semantic-conventions that referenced this issue Mar 21, 2024
* Add OTEL_SERVICE_NAME environment variable

Closes open-telemetry#709
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants