Make sure database instrumentations follow semantic conventions

[lzchen]

From specs.

[srikanthccv]

Hi @lzchen, I would like to work on this.

I have read the specification and gone through some database instrumentations. Here are the thins I noticed.

1. Spec has db.system for DBMS identifier but the instrumentations have db.type.
2. Similar to 1 as per spec db.name is used to report the name of the database being accessed but db.instance is created for instrumentations.
3. Redis doesn't seem to have any one of [net.peer.name, net.peer.ip] .

[srikanthccv]

Hi @lzchen , I tried to address this here.

@toumorokoshi left some comments I think there's still some reconciliation that needs to happen on the specification and the fields emitted, especially on the MongoDB side.

Some db specific call level attributes are added which are not mentioned in spec. What are your thoughts on this?

[toumorokoshi]

Hey @lonewolf3739! Sorry about the hassle, but would you mind sending your PR again? I think the libraries moved to this repo while this PR was still in discussion.

Regarding:

I think there's still some reconciliation that needs to happen on the specification and the fields emitted, especially on the MongoDB side.

Here's a spec ticket to start a discussion. I think some of this may be follow-up work as well, so the PR as-is would be great to merge in.

[srikanthccv]

@toumorokoshi I don't mind opening PR here again. I just wanted to see if others can chime in and share their opinions.

[lzchen]

@lonewolf3739

I don't mind opening PR here again. I just wanted to see if others can chime in and share their opinions.

The extra attributes not defined in the specs can be left until the specs are finalized.

[github-actions]

This issue was marked stale due to lack of activity. It will be closed in 30 days.

[awssandra]

Are there any more remaining?

[srikanthccv]

@awssandra We haven't made any changes since last time. I think there would be some gaps between the specification and current implementation.

[srikanthccv]

I will create a new issue with the same title and epic containing all the db instrumentations.