Skip to content

Align env carrier empty-key normalization with spec#86

Merged
bryce-b merged 1 commit into
open-telemetry:mainfrom
pellared:env-car-empty
Jul 2, 2026
Merged

Align env carrier empty-key normalization with spec#86
bryce-b merged 1 commit into
open-telemetry:mainfrom
pellared:env-car-empty

Conversation

@pellared

Copy link
Copy Markdown
Member

@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@4f85f2a). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #86   +/-   ##
=======================================
  Coverage        ?   69.20%           
=======================================
  Files           ?      231           
  Lines           ?     8255           
  Branches        ?        0           
=======================================
  Hits            ?     5713           
  Misses          ?     2542           
  Partials        ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pellared added a commit to pellared/opentelemetry-specification that referenced this pull request Jun 22, 2026
…try#5163)

Issue discovered by @MrAlias in
open-telemetry/opentelemetry-go-contrib#9112 (comment)

Also see
open-telemetry#5163 (comment)

Prototypes: 
-
open-telemetry/opentelemetry-go-contrib@0fedf62
- open-telemetry/opentelemetry-dotnet#7424
- open-telemetry/opentelemetry-swift-core#86
- open-telemetry/opentelemetry-python#5328
- open-telemetry/opentelemetry-js#6827
- open-telemetry/opentelemetry-java#8481

For values to be fully portable across POSIX-compliant systems and shell
utilities, the standard dictates that environment variable names must
consist solely of uppercase letters, digits, and underscores (_), and
must not begin with a digit. While some individual implementations might
tolerate unusual characters, an empty string lacks any valid characters
entirely and cannot act as a recognizable identifier.

I verified that on Ubuntu it is not possible to set a env var with an
empty name.

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@bryce-b
bryce-b merged commit af73ee9 into open-telemetry:main Jul 2, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants