feat(propagator-env-carrier): empty name normalization#6827
Merged
Conversation
pellared
marked this pull request as ready for review
June 18, 2026 19:38
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6827 +/- ##
=======================================
Coverage 94.93% 94.93%
=======================================
Files 383 383
Lines 13007 13009 +2
Branches 2974 2975 +1
=======================================
+ Hits 12348 12350 +2
Misses 659 659
🚀 New features to boost your workflow:
|
trentm
approved these changes
Jun 18, 2026
Member
Author
|
@trentm, can you also review open-telemetry/opentelemetry-specification#5163 given you approved and merged this PR? |
pellared
added a commit
to pellared/opentelemetry-specification
that referenced
this pull request
Jun 22, 2026
…try#5163) Issue discovered by @MrAlias in open-telemetry/opentelemetry-go-contrib#9112 (comment) Also see open-telemetry#5163 (comment) Prototypes: - open-telemetry/opentelemetry-go-contrib@0fedf62 - open-telemetry/opentelemetry-dotnet#7424 - open-telemetry/opentelemetry-swift-core#86 - open-telemetry/opentelemetry-python#5328 - open-telemetry/opentelemetry-js#6827 - open-telemetry/opentelemetry-java#8481 For values to be fully portable across POSIX-compliant systems and shell utilities, the standard dictates that environment variable names must consist solely of uppercase letters, digits, and underscores (_), and must not begin with a digit. While some individual implementations might tolerate unusual characters, an empty string lacks any valid characters entirely and cannot act as a recognizable identifier. I verified that on Ubuntu it is not possible to set a env var with an empty name. --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows open-telemetry/opentelemetry-specification#5163