Skip to content

Clarify span status guidance for HTTP spans #537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 14, 2020
Merged

Clarify span status guidance for HTTP spans #537

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6cb6fe1
Clarify span status guidance for HTTP spans
arminru Mar 31, 2020
d552c00
Wording
arminru Mar 31, 2020
91f29e3
More (actually less) wording
arminru Mar 31, 2020
7e257db
Merge branch 'master' into arminru-http-span-status
arminru Apr 13, 2020
1f5b20b
Fix link after directory restructuring
arminru Apr 13, 2020
335939c
Merge branch 'master' into arminru-http-span-status
carlosalberto Apr 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions specification/trace/semantic_conventions/http.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ default span name.

## Status

Implementations MUST set status if the HTTP communication failed
Implementations MUST set the [span status](../api.md#status) if the HTTP communication failed
or an HTTP error status code is returned (e.g. above 3xx).

In the case of an HTTP redirect, the request should normally be considered successful,
unless the client aborts following redirects due to hitting some limit (redirect loop).
If following a (chain of) redirect(s) successfully, the Status should be set according to the result of the final HTTP request.
If following a (chain of) redirect(s) successfully, the status should be set according to the result of the final HTTP request.

Don't set a status message if the reason can be inferred from `http.status_code` and `http.status_text` already.
Don't set the span status description if the reason can be inferred from `http.status_code` and `http.status_text`.

| HTTP code | Span status code |
|-------------------------|-----------------------|
Expand Down