Skip to content

Conversation

@arminru
Copy link
Member

@arminru arminru commented Mar 31, 2020

It was not clear if "status message" refers to the general span status description or the HTTP reason phrase (see Gitter request).

@bogdandrutu
Copy link
Member

@arminru
Copy link
Member Author

arminru commented Apr 2, 2020

@bogdandrutu Sorry about that, I used the Edit✏️ feature right from the Github website which only allows me to commit on a branch since I have write access to the repo, otherwise it would've used my own fork. I thought it wouldn't matter since that's a change that I expected to merge rather instantly anyway. I'll use the more cumbersome manual approach on my local machine in future then to avoid this. 🙂

@Oberon00
Copy link
Member

Oberon00 commented Apr 2, 2020

@bogdandrutu You should make a PR to add this caveat to CONTRIBUTING.md for people with write-access to take care of. I suspect there will be push-back however 😉

@bogdandrutu
Copy link
Member

@Oberon00 I added the links there is already in the contributing reference to that

@arminru arminru force-pushed the arminru-http-span-status branch from 7dec966 to 91f29e3 Compare April 7, 2020 07:56
@carlosalberto carlosalberto merged commit bfb060b into master Apr 14, 2020
@carlosalberto carlosalberto deleted the arminru-http-span-status branch April 14, 2020 14:54
@carlosalberto
Copy link
Contributor

Merged - this was a relatively minor clarification and had two approvals already (but had been standing forgotten for some time now ;( )

carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
schmikei pushed a commit to schmikei/opentelemetry-specification that referenced this pull request Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants