Skip to content
Closed
Changes from 1 commit
Commits
Show all changes
104 commits
Select commit Hold shift + click to select a range
ad32e17
Updated Zipkin spec for remoteEndpoint mapping.
CodeBlanch Mar 29, 2020
8c2d6c2
SpanContext.IsRemote is false on remote children (#538)
toumorokoshi Apr 1, 2020
0ea77a9
Enable markdown-link-check (#541)
bogdandrutu Apr 2, 2020
bdf39cb
Move specifications into sub-directories per signal (#546)
bogdandrutu Apr 6, 2020
6b29667
Define span attributes for messaging systems (#418)
arminru Apr 7, 2020
03066b7
Add Semantic Conventions for Function as a Service (#471)
thisthat Apr 7, 2020
a3abf90
update circleci to use go 1.14 (#553)
andrewhsu Apr 8, 2020
86090a3
sdk-tracing: Fix section hierarchy (#545)
Oberon00 Apr 8, 2020
c04041e
Fix markdown-link-check and dead links (#555)
arminru Apr 9, 2020
d749036
Add missing link (#561)
thisthat Apr 10, 2020
e0bd417
Remove the handling of retries from exporters. (#511)
jkwatson Apr 13, 2020
46fd2dc
Remove LabelSet (#560)
c24t Apr 14, 2020
bfb060b
Clarify span status guidance for HTTP spans (#537)
arminru Apr 14, 2020
494bb6d
Remove default keys from metrics spec (#565)
jmacd Apr 16, 2020
d692dfb
Add payload size to messaging semantic conventions (#550)
arminru Apr 17, 2020
1c5f504
Clarify messaging.system. (#558)
Oberon00 Apr 22, 2020
1a64b25
Unify roadmap to be at opentelemetry.io (#551)
MrAlias Apr 22, 2020
1c0135a
Add Logs Glossary document (#540)
tigrannajaryan Apr 22, 2020
e2fd00b
Fix broken links in glossary.md (#573)
tigrannajaryan Apr 23, 2020
f8f8dc3
Add some clarifying language to the semantics of metric instrument na…
jkwatson Apr 23, 2020
89efe15
Document special Zipkin conversion cases (#566)
pavolloffay Apr 28, 2020
be41164
Fix HTTP span example (#576)
arminru Apr 28, 2020
c03fe50
Add a small explanation on why Restore is needed. (#563)
carlosalberto Apr 28, 2020
e7fe34a
Allow injectors and extractors to be separate interfaces (#578)
mwear Apr 30, 2020
7f64aef
Fix links to oteps after they were moved (#589)
bogdandrutu May 6, 2020
e2ff02d
Update link to otep 0059, moved to trace (#590)
bogdandrutu May 7, 2020
27e5c89
Metric API v0.4 specification (#581)
jmacd May 8, 2020
eef502f
[build] Improve markdown-link-check output (#602)
arminru May 13, 2020
1de415d
Link from trace (and metric) semantic conventions to resources (#603)
arminru May 14, 2020
18b2752
Recommend custom header "otcorrelations" over w3c correlation-context…
dyladan May 14, 2020
784635d
normalize term for instrumentations (#539)
toumorokoshi May 18, 2020
f9aabe2
Replace ALWAYS_PARENT with a composite ParentOrElse sampler (#609)
bogdandrutu May 18, 2020
237ab5f
Fix instrumentation library synonym (#612)
MrAlias May 19, 2020
0121fc9
Makefile fixes (#615)
jmacd May 20, 2020
1a0395e
Tracers reference an InstrumentationLibrary rather than a Resource (#…
mwear May 21, 2020
df48497
add vendors.md doc about what it means to support opentelemetry (#594)
tsloughter May 21, 2020
5b78ee1
Metrics API specification: incorporate old content on calling convent…
jmacd May 21, 2020
e2f6ff4
Remove SpanId from Sampler input (#621)
reyang May 28, 2020
cbeb0ec
zipkin service name (#472)
SergeyKanzhelev May 30, 2020
77693e4
remove OpenCensus exporter requirement from the library guideline (#631)
reyang Jun 2, 2020
1729bc4
Update CHANGELOG with 0.4.0/0.5.0 (#633)
carlosalberto Jun 3, 2020
f78d35f
propose experimental folder (#632)
SergeyKanzhelev Jun 9, 2020
a4c012a
Improve root span description (#645)
tigrannajaryan Jun 12, 2020
b8566d0
Add link to version attribute schemas (#643)
tigrannajaryan Jun 12, 2020
5aae909
Setting naming convention for exporter packages (#629)
toumorokoshi Jun 12, 2020
6f47d03
Clean up Tracing API spec, clarify Tracer vs TracerProvider. (#619)
Oberon00 Jun 15, 2020
95ec22d
docs: change SumObserver to UpDownSumObserver because before we were …
DotSpy Jun 15, 2020
d46c361
Add span attribute to indicate cold starts of Function as a Service e…
arminru Jun 15, 2020
99b31d4
Extend semantic conventions for RPC and allow non-gRPC calls (#604)
arminru Jun 17, 2020
4a8ee03
Update codeowners to support area owners (#661)
bogdandrutu Jun 22, 2020
0905ea6
Fix CODEOWNERS syntax (#670)
arminru Jun 24, 2020
9e8c5f1
Add semantic conventions for http content size (#641)
anuraaga Jun 25, 2020
462b64a
Added semantic conventions for the "process" resource (#635)
james-bebbington Jun 30, 2020
4a2fd06
Add semantic conventions for container id (#673)
wangzlei Jun 30, 2020
1d9006d
Change "ordered mapping" to "collection of key-value pairs" (#646)
tigrannajaryan Jun 30, 2020
4daee3a
Clarify semantic conventions around span start and end time (#592)
toumorokoshi Jun 30, 2020
b70565d
Add peer.service semantic convention to indicate the name of a target…
anuraaga Jun 30, 2020
0c6f484
Exclude github.com from markdown-link-check (#675)
arminru Jul 1, 2020
b338f9f
Do not write a value in Context upon failed extraction. (#671)
carlosalberto Jul 1, 2020
6c86748
Revise and extend semantic conventions for databases (#575)
arminru Jul 1, 2020
c8554d8
Remove ZPagesProcessor mentioned in SDK spec (#683)
arminru Jul 1, 2020
8b25420
Update CHANGELOG with 0.6.0 changes. (#685)
carlosalberto Jul 1, 2020
4ea4d27
Fix links that weren't working (#688)
jajanet Jul 3, 2020
e69bde6
typos (#687)
shrapx Jul 4, 2020
709293f
Fix Redis sample (db.redis.database_index was missing) (#692)
arminru Jul 9, 2020
f4e6d6e
Update resource `process.*` descriptions (#695)
MrAlias Jul 10, 2020
0434a7b
Add mapping for nginx 499 http status (#677)
Jul 10, 2020
3e34565
Use OTel as the official acronym in the README. (#700)
carlosalberto Jul 14, 2020
c5b1dfd
Add issue/PR templates (#701)
reyang Jul 14, 2020
27010e5
Add resource semantic conventions for operating systems (#693)
arminru Jul 15, 2020
b610b07
Fix typo (#702)
reyang Jul 15, 2020
363e339
Adapt semantic conventions for the span name of messaging systems (#690)
arminru Jul 15, 2020
bd98664
Unify the batch span processor parameters (#708)
MrAlias Jul 17, 2020
15c41b1
Add an addendum for allowing async/callback export return results. (#…
jkwatson Jul 17, 2020
587beba
specify how probability sampler is used with ParentOrElse (#704)
dyladan Jul 17, 2020
29fccfe
Exception reporting specification (#697)
mwear Jul 17, 2020
b8948d9
Small clean up for Propagators. (#577)
carlosalberto Jul 20, 2020
6b6ca2a
Describe in-band and out-of-band terms (#714)
yurishkuro Jul 20, 2020
cfb6e9e
Clarify concurrency requirements for trace and metrics (#720)
bogdandrutu Jul 21, 2020
36a95cd
Move concurrency requirements to the API files (#724)
bogdandrutu Jul 22, 2020
d2665fd
Centralize attributes definition (#722)
bogdandrutu Jul 22, 2020
f26c57a
Add log data model (#694)
tigrannajaryan Jul 22, 2020
619b588
Split resource semantic conventions in smaller files (#727)
bogdandrutu Jul 23, 2020
b054648
fix link 'Log Data Model' (#733)
AntonDzyk Jul 24, 2020
de3b65e
Add semantic conventions for all Kubernetes objects (#732)
bogdandrutu Jul 25, 2020
c33919e
DocFX sanity check (#742)
reyang Jul 27, 2020
7ae3d06
Change the default sampler to ParentOrElse(AlwaysOn) (#750)
MitchellDumovic Jul 29, 2020
6468f8a
Trace SDK: Provide definitions for readable and read/write span. (#669)
Oberon00 Aug 1, 2020
fcc4ac6
Remove warnings about Span.UpdateName (#754)
iNikem Aug 3, 2020
ea15a2d
Close stale PRs (#744)
iNikem Aug 3, 2020
b4e327c
Minor edits to the SpanContext (#741)
cijothomas Aug 3, 2020
66a6dc6
Clean up R/W span spec. (#756)
Oberon00 Aug 5, 2020
8e7b2cc
Add logs overview (#737)
tigrannajaryan Aug 5, 2020
3891524
Specify the initial propagators requirements. (#735)
carlosalberto Aug 5, 2020
3fce938
add initial env var draft specification (#666)
mwear Aug 5, 2020
98bc818
Clarify how to make progress on a PR (#745)
reyang Aug 6, 2020
91590d9
Add Empty array (#760)
thisthat Aug 6, 2020
0bc38e4
Use OTEL_RESOURCE_ATTRIBUTES instead of OTEL_RESOURCE_LABELS. (#758)
carlosalberto Aug 6, 2020
e8b5802
k8s: Differentiate container spec name and container name (#762)
asuresh4 Aug 7, 2020
e6a4a8d
Add Global Error Handler (#757)
MitchellDumovic Aug 7, 2020
4d879e0
Specify technical-committee explicitly to allow random assignment of …
bogdandrutu Aug 10, 2020
a719697
Move RemoteEndpoint to new location with updates.
CodeBlanch Aug 11, 2020
ebcee97
Fixed casing of remoteEndpoint.
CodeBlanch Aug 11, 2020
0231d7b
Merging master.
CodeBlanch Aug 11, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion specification/exporter-zipkin.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ Zipkin fields:

- Service name
- Local_endpoint
- Remote_endpoint
- debug
- Shared

Expand All @@ -64,6 +63,22 @@ Zipkin.
| `SpanKind.PRODUCER`|`SpanKind.PRODUCER` ||
|`SpanKind.INTERNAL`|`null` |must be omitted (set to `null`)|

### Remote endpoint

If Zipkin `SpanKind` resolves to either `SpanKind.CLIENT` or `SpanKind.PRODUCER` then the service SHOULD specify remote endpoint otherwise Zipkin won't treat the Span as a dependency. OpenTelemetry doesn't have a perfectly expressive field for the destination service, so the following mapping is applied:

|Priority|Attribute Name|Reason|
|---|---|---|
|1|net.peer.name|[OpenTelemetry adopted attribute for remote hostname, or similar.](./data-span-general.md#general-network-connection-attributes)|
|1|peer.service|Remote service name defined in OpenTracing specification.|
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh actually I noticed some values have same priority - what's the decision mechanism within a priority?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anuraaga There was a note in there below the table about what to do in that case, but I cleaned it up and simplified things for #776. I put peer.service at the top. We have been using that in opentelemetry-dotnet for a while, just didn't update this doc 😄

|2|peer.hostname|Remote hostname defined in OpenTracing specification.|
|2|peer.address|Remote address defined in OpenTracing specification.|
|2|net.peer.ip & net.peer.port|[OpenTelemetry adopted attribute for remote address of the peer.](./data-span-general.md#general-network-connection-attributes)|
|3|http.host|Commonly used address attribute for Http Spans.|
|3|db.instance|Commonly used address attribute for DB Spans.|

Lowest priority match should be selected. In the event that multiple hits occur at the same priority level (Ex: `net.peer.name` & `peer.service` are both specified), take the value from the first attribute matched. `net.peer.ip` can be used by itself as remote endpoint but should be combined with `net.peer.port` if it is also present.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Lowest priority match should be selected." So the lowest priority match has the highest priority? 😕

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh :) For whatever reason, it doesn't bug me. Think about a priority 1 issue vs a priority 5? Sometimes lower is more urgent. But I'm happy to change it to reduce confusion. How about "rank" instead?


### Attribute

OpenTelemetry Span `Attribute`(s) MUST be reported as `tags` to Zipkin.
Expand Down