Updated Zipkin spec for remoteEndpoint mapping. #776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuraaga
approved these changes
Aug 11, 2020
Member
Author
Rebase didn't go so hot 😭 Decided to just recreate. |
Member
Author
|
@alanwest We were talking about this the other day. I actually had in the doc that port should be added with ip if it is available, I just forget about it. |
carlosalberto
approved these changes
Aug 12, 2020
bogdandrutu
reviewed
Aug 12, 2020
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
bogdandrutu
approved these changes
Aug 21, 2020
SergeyKanzhelev
approved these changes
Aug 27, 2020
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
* Added remoteEndpoint section in zipkin spec. * Review feedback. * Update zipkin.md Co-authored-by: Bogdan Drutu <[email protected]> Co-authored-by: Sergey Kanzhelev <[email protected]>
schmikei
pushed a commit
to schmikei/opentelemetry-specification
that referenced
this pull request
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreated PR (old one was #534).