-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "advice" to "advisory parameters" #3662
Conversation
1e2f0e1
to
c464a7c
Compare
Why not using "hints" (which was the original name that we've been using during the discussion)? @jack-berg
+1 |
It would need to be "hints parameters" still to indicate that these are a category of parameters, right? |
I don't think that would address #3621, as it is still a noun, which implicitly is a parameter. "hint parameters" would work, but I don't have a strong opinion on advice/advisory parameter vs hint/hint parameter edit: tyler beat me to it |
I was thinking about SDK View https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/sdk.md#view.
Whether Views are provided as a single argument or multiple arguments is up to the implementation. Hints can be handled using the same way. |
See my reply here #3662 (comment). Another thing to consider - do we want to stop folks from using a single parameter for all advice/hints? I don't see a strong reason why we want to have such preference. |
35dc3ef
to
cc829ac
Compare
The only piece of this I'm not sure whether or not it's missing is the bit @jack-berg / @MrAlias were discussing regarding having a firm description of which advice to accept in the event you have two registration events with conflicting advice (i.e. the whole first-seen-by-runtime verbage). You may have it in this PR and I missed it, or it's covered by some other section of the spec and I also failed to recall. Just want to make sure that's covered. |
That was done in #3661. |
Fixes #3621
Changes
advice
toadvisory parameters
. The intention is to change advice from implicitly being a concrete parameter to being a category of parameter.@jack-berg @jsuereth is this something like what you had in mind? Some alternative approaches we could consider if we want to keep "advice" as a noun: