-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider allowing a simpler API for histogram default buckets #3621
Comments
"When prototyping in Go, 'Advice' itself seemed unnecessary for allowing histogram bucket boundaries to be configured on histogram instruments" should be "When prototyping in Go, 'Advice' itself seemed unnecessary for allowing histogram bucket boundaries to be configured on anything but histogram instruments", right? |
I meant to say that configuring buckets directly, rather than nested inside of advice, was simpler. I.e. advice was not necessary for allowing buckets to be configured on histograms. Your statement is also correct that histogram bucket boundary configuration didn't make sense to include as options for non-histogram instruments. |
Gotcha 👍 |
just fyi, I've added this to the spec meeting agenda for discussion since it's potentially a blocker for #3391 which is a blocker for HTTP semconv stability |
This seems reasonable. |
Notes from the SIG meeting:
|
Context
This is feedback from a Go prototype of the Instrument Advice API:
Feedback
When prototyping in Go, "Advice" itself seemed unnecessary for allowing histogram bucket boundaries to be configured on histogram instruments. The simplest, cleanest API was to make bucket boundary configuration a "top-level" configuration option exclusive to histograms, rather than nested within an "Advice" concept.
The ask in this issue is to at least allow API implementations to exclude the notion of Advice, and instead allow directly configuring the subfields of Advice on the instruments they apply to.
cc @jack-berg @MrAlias @MadVikingGod
The text was updated successfully, but these errors were encountered: