Promote MetricProducer and MetricReader.RegisterProducer specification to feature-freeze #3600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @open-telemetry/specs-metrics-approvers |
…n to feature-freeze
dashpole
force-pushed
the
producer_freeze
branch
from
2ac2535 to
d54a51b
Compare
|
@dashpole for this PR, I suggest we gather approvals from language SIG maintainers who have done prototyping. |
reyang
approved these changes
Jul 14, 2023
|
@aabmass do you know which maintainers would be able to vouch for the JS implementation? |
damemi
approved these changes
Jul 14, 2023
MrAlias
approved these changes
Jul 14, 2023
jmacd
approved these changes
Jul 17, 2023
This isn't implemented in JS yet, I'm working on it now. |
dashpole
force-pushed
the
producer_freeze
branch
from
69a5f78 to
d54a51b
Compare
|
I split out the parameter clarification into its own PR: #3612. This now only promotes MetricProducer |
|
Converting to draft while we discuss alternatives in #3599. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3599. See the issue for the rationale for promotion.