Skip to content

Commit

Permalink
clarify parameters of the MetricProducer.Produce()
Browse files Browse the repository at this point in the history
  • Loading branch information
dashpole committed Jul 14, 2023
1 parent d54a51b commit 69a5f78
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ release.

### Metrics

- Promote MetricProducer and MetricReader.RegisterProducer specification to feature-freeze.
- Promote MetricProducer and MetricReader.RegisterProducer specification to feature-freeze, and clarify Produce() parameters.
([#3600](https://github.com/open-telemetry/opentelemetry-specification/pull/3600))

### Logs
Expand Down
3 changes: 2 additions & 1 deletion specification/metrics/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -1422,7 +1422,8 @@ A `MetricProducer` MUST support the following functions:
`Produce` provides metrics from the MetricProducer to the caller. `Produce`
MUST return a batch of [Metric points](./data-model.md#metric-points).
`Produce` does not have any required parameters, however, [OpenTelemetry
SDK](../overview.md#sdk) authors MAY choose to add parameters (e.g. timeout).
SDK](../overview.md#sdk) authors MAY choose to add required or optional
parameters (e.g. timeout).

`Produce` SHOULD provide a way to let the caller know whether it succeeded,
failed or timed out. When the `Produce` operation fails, the `MetricProducer`
Expand Down

0 comments on commit 69a5f78

Please sign in to comment.