-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add back refs to cloud.resource_id lost in FaaS renaming. #3329
Merged
carlosalberto
merged 4 commits into
open-telemetry:main
from
dynatrace-oss-contrib:feature/faas-cloud-id-ref
Apr 11, 2023
Merged
Add back refs to cloud.resource_id lost in FaaS renaming. #3329
carlosalberto
merged 4 commits into
open-telemetry:main
from
dynatrace-oss-contrib:feature/faas-cloud-id-ref
Apr 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
added
area:semantic-conventions
Related to semantic conventions
spec:resource
Related to the specification/resource directory
spec:trace
Related to the specification/trace directory
editorial
Editorial changes only (typos, changelog, ...). No content-related changes of any kind.
labels
Mar 21, 2023
Oberon00
commented
Mar 21, 2023
These places were removed when open-telemetry#3188 in its original form removed faas.id without replacement and weren't added back after changing it to introduce cloud.resource_id instead.
Oberon00
force-pushed
the
feature/faas-cloud-id-ref
branch
from
March 21, 2023 14:45
616bd97
to
36f468c
Compare
CC @tylerbenson @lmolkova (as you were involved in #3188) |
arminru
approved these changes
Mar 28, 2023
tylerbenson
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
carlosalberto
approved these changes
Apr 7, 2023
jsuereth
approved these changes
Apr 10, 2023
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
…etry#3329) These places were removed when open-telemetry#3188 in its original form removed faas.id without replacement and weren't added back after changing it to introduce cloud.resource_id instead. Editorial change, no CHANGELOG or issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:semantic-conventions
Related to semantic conventions
editorial
Editorial changes only (typos, changelog, ...). No content-related changes of any kind.
spec:resource
Related to the specification/resource directory
spec:trace
Related to the specification/trace directory
Stale
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These places were removed when #3188 in its original form removed faas.id without replacement and weren't added back after changing it to introduce cloud.resource_id instead.
Editorial change, no CHANGELOG or issue.