-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand scope of faas.id
to cloud.resource_id
#3188
Conversation
46cc53f
to
a2aa3bb
Compare
FYI. I've pulled the first two commits out into a separate PR #3209. I'll try moving |
As per the discussion on open-telemetry#3188, we determined it is better to move rather than remove as this attribute is still important for some systems despite it containing duplicated information.
fa58b5e
to
a2db39a
Compare
faas.id
to cloud.resource_id
As per the discussion on open-telemetry#3188, we determined it is better to move rather than remove as this attribute is still important for some systems despite it containing duplicated information.
a2db39a
to
71d6dac
Compare
Hey @Oberon00
You mean adding a reference/link from the FaaS semconv table to this section? |
Co-authored-by: Christian Neumüller <[email protected]>
Btw @Oberon00 Following on this: once we decide how to proceed with open-telemetry/oteps#222 we should also double check expectations here regarding ECS. FWIW I think ECS is a better, clearer, cleaner semconv reference, with |
Exactly (using the |
I think you should decide on this rather sooner than later otherwise lots of work on the semantic conventions (such as this PR) and also potentially the tooling may go to waste. |
# Conflicts: # schemas/1.19.0 # specification/resource/semantic_conventions/faas.md # specification/trace/semantic_conventions/faas.md # specification/trace/semantic_conventions/instrumentation/aws-lambda.md
## Changes As per the discussion on open-telemetry#3188, we determined it is better to move rather than remove as this attribute is still important for some systems despite it containing duplicated information.
These places were removed when open-telemetry#3188 in its original form removed faas.id without replacement and weren't added back after changing it to introduce cloud.resource_id instead.
These places were removed when open-telemetry#3188 in its original form removed faas.id without replacement and weren't added back after changing it to introduce cloud.resource_id instead.
These places were removed when #3188 in its original form removed faas.id without replacement and weren't added back after changing it to introduce cloud.resource_id instead. Editorial change, no CHANGELOG or issue.
…26486) Context: GoogleCloudPlatform/opentelemetry-operations-go#679 faas.id was removed from the semantic conventions: open-telemetry/opentelemetry-specification#3188 We were previously using it improperly to store the instance id of the faas, which should be mapped to faas.instance instead. --------- Co-authored-by: Alex Boten <[email protected]>
…pen-telemetry#26486) Context: GoogleCloudPlatform/opentelemetry-operations-go#679 faas.id was removed from the semantic conventions: open-telemetry/opentelemetry-specification#3188 We were previously using it improperly to store the instance id of the faas, which should be mapped to faas.instance instead. --------- Co-authored-by: Alex Boten <[email protected]>
## Changes As per the discussion on open-telemetry#3188, we determined it is better to move rather than remove as this attribute is still important for some systems despite it containing duplicated information.
…etry#3329) These places were removed when open-telemetry#3188 in its original form removed faas.id without replacement and weren't added back after changing it to introduce cloud.resource_id instead. Editorial change, no CHANGELOG or issue.
Changes
As per the discussion on #3188, we determined it is better to move rather than remove as this attribute is still important for some systems despite it containing duplicated information.