-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prometheus histogram bucket metric ends in _bucket #3018
Conversation
cc @gouthamve @jmacd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cc @open-telemetry/wg-prometheus |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
@carlosalberto can you reopen? |
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
54857dc
to
49994eb
Compare
49994eb
to
3bf5d1d
Compare
I believe this can be merged. |
I realized when opening open-telemetry/opentelemetry-swift#355 that the current prometheus spec for histograms is incorrect (though almost all implementations of prometheus exporters is correct).
From the prometheus spec:
From the OpenMetrics spec:
This corrects our specification to be in-line with prometheus and OM specs