Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus histogram bucket metric ends in _bucket #3018

Merged
merged 3 commits into from
Jan 20, 2023

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented Dec 7, 2022

I realized when opening open-telemetry/opentelemetry-swift#355 that the current prometheus spec for histograms is incorrect (though almost all implementations of prometheus exporters is correct).

From the prometheus spec:

Each bucket count of a histogram named x is given as a separate sample line with the name x_bucket and a label {le="y"} (where y is the upper bound of the bucket).

From the OpenMetrics spec:

The MetricPoint's Bucket Values Sample MetricNames MUST have the suffix "_bucket".

This corrects our specification to be in-line with prometheus and OM specs

@dashpole dashpole requested review from a team December 7, 2022 00:42
@dashpole
Copy link
Contributor Author

dashpole commented Dec 7, 2022

cc @gouthamve @jmacd

Copy link
Member

@gouthamve gouthamve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dashpole
Copy link
Contributor Author

cc @open-telemetry/wg-prometheus

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 21, 2022
@github-actions
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Dec 28, 2022
@dashpole
Copy link
Contributor Author

dashpole commented Jan 3, 2023

@carlosalberto can you reopen?

@jack-berg jack-berg reopened this Jan 4, 2023
@github-actions github-actions bot removed the Stale label Jan 5, 2023
@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 20, 2023

Verified

This commit was signed with the committer’s verified signature.
dashpole David Ashpole

Verified

This commit was signed with the committer’s verified signature.
dashpole David Ashpole
@dashpole
Copy link
Contributor Author

I believe this can be merged.

@MrAlias MrAlias removed the Stale label Jan 20, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@reyang reyang merged commit df03f5e into open-telemetry:main Jan 20, 2023
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants