Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus exporter: histogram bucket series must have _bucket suffix #355

Open
dashpole opened this issue Dec 6, 2022 · 0 comments
Open
Labels
metrics Metrics feature or improvement

Comments

@dashpole
Copy link

dashpole commented Dec 6, 2022

From the prometheus spec:

Each bucket count of a histogram named x is given as a separate sample line with the name x_bucket and a label {le="y"} (where y is the upper bound of the bucket).

The current implementation does not add a _bucket suffix. There is a prometheusHistogramBucketPostFix variable defined, but it is not used: https://github.com/open-telemetry/opentelemetry-swift/blob/main/Sources/Exporters/Prometheus/PrometheusExporterExtensions.swift#L107-L115

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics Metrics feature or improvement
Projects
None yet
Development

No branches or pull requests

2 participants