-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for the metrics SDK experimental release #1912
Prepare for the metrics SDK experimental release #1912
Conversation
Hi @reyang - I'm curious to get your (and others) thoughts on when best to resolve Issue #1902 regarding some sort of support for a min, max, sum, count style aggregation. The current thought is that we can achieve this by extending the histogram proto with optional min / max fields. If we went down this route, it would be nice to have this type of histogram specified in the SDK spec. Specifically, I think we could add a Personally, I think it would be valuable to make this aggregation available in the experimental release. |
@jack-berg Adding min/max fields to histogram proto would be part of "metrics data model" specification. If we add min/max there, then implicitly histogram aggregators will need to be updated to support it. I think that, combined with providing no buckets to histogram explicit bucket will get you exactly what you want out of Happy to help shepherd you through the process and drive Prs on appropriate repositories. |
@jack-berg thanks for calling this out. I think these are not blockers for SDK spec Experimental release, and this is definitely a nice-to-have and we should get it before Feature-freeze. Here goes the 09/07/2021 #196 Metrics SIG meeting notes. There are several parts I could imagine:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, pending PRs listed as blocking.
* prepare for the metrics sdk experiemental release * update changelog * update changelog
This PR is pending on #1888 and #1913 to be merged.
Changes: