-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add min/max fields to HistogramDataPoint #279
Conversation
Note the idea would be to apply this to the Histogram point after PR #272. |
This is stale and we may revisit this topic after other histogram work is finished. |
I modified this PR to use proto3 "optional" which means to use explicit presence, see this document: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that #322 has been merged, should this PR add min/max fields for ExponentialHistogram
too?
The build says:
|
I believe with open-telemetry/opentelemetry-collector#4929 this is now fully unblocked. @jmacd please rebase the branch |
Thank you @codeboten! |
@bogdandrutu please review |
@jmacd @codeboten as in any ideal world, we should start with fixing a bug first #336 than adding new functionality. Should we merge the |
Either one is fine with me @bogdandrutu, I don't think I have permissions to push changes to #336 to unblock the PR 😬 |
Let’s fix that first. Maybe clone that PR and open a new one with necessary changes. |
@bogdandrutu see #366 |
@codeboten I want to do a release #367 then start using this in collector to prove everything is fine, then will merge this. |
This is really annoying. It means opentelemetry isn't build-able or usable on ubuntu bionic with upstream provided packages. |
Adds a definition for min and max in the Histogram data point.
See the definition of these fields in the data model.
Fixes #266.