Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memcached to db.system semantic conventions #1689

Merged
merged 7 commits into from
May 17, 2021
Merged

Add memcached to db.system semantic conventions #1689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
04aefd4
Add memcached to db.system semantic conventions
ericmustin May 12, 2021
d7b1896
update yaml to include memcache in db table
ericmustin May 12, 2021
60a9b5f
add memcache change to changelog
ericmustin May 12, 2021
071c7e0
Merge branch 'main' into patch-1
carlosalberto May 13, 2021
3aa42db
Merge branch 'main' into patch-1
carlosalberto May 14, 2021
df47e4c
Fix entry in CHANGELOG.md
arminru May 17, 2021
da96b41
Merge branch 'main' into patch-1
carlosalberto May 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ release.

- Add JSON RPC specific conventions ([#1643](https://github.com/open-telemetry/opentelemetry-specification/pull/1643)).

- Add Memcached to Database specific conventions ([#1689](https://github.com/open-telemetry/opentelemetry-specification/pull/1689)).

### Compatibility

### OpenTelemetry Protocol
Expand Down
3 changes: 3 additions & 0 deletions semantic_conventions/trace/database.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,9 @@ groups:
- id: elasticsearch
value: 'elasticsearch'
brief: 'Elasticsearch'
- id: memcached
value: 'memcached'
brief: 'Memcached'
- id: connection_string
tag: connection-level
type: string
Expand Down
1 change: 1 addition & 0 deletions specification/trace/semantic_conventions/database.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ Some database systems may allow a connection to switch to a different `db.user`,
| `neo4j` | Neo4j |
| `geode` | Apache Geode |
| `elasticsearch` | Elasticsearch |
| `memcached` | Memcached |
<!-- endsemconv -->

### Notes and well-known identifiers for `db.system`
Expand Down