Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add memcached to db.system semantic conventions #1689

Merged
merged 7 commits into from
May 17, 2021

Conversation

ericmustin
Copy link
Contributor

As we already use memcached to represent the db.system Memcached in opentelemetry-python, I believe we should add to the specification recommendation https://github.com/open-telemetry/opentelemetry-python-contrib/blob/e606542981580971af1bbecbf07671c39f799665/instrumentation/opentelemetry-instrumentation-pymemcache/src/opentelemetry/instrumentation/pymemcache/__init__.py#L160

Fixes #

Changes

Please provide a brief description of the changes here. Update the
CHANGELOG.md for non-trivial changes. If CHANGELOG.md is updated,
also be sure to update spec-compliance-matrix.md if necessary.

Related issues #

Related oteps #

@arminru arminru added area:semantic-conventions Related to semantic conventions spec:trace Related to the specification/trace directory labels May 12, 2021
Copy link
Member

@arminru arminru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add this to the changelog. Thanks!

CHANGELOG.md Outdated Show resolved Hide resolved
@carlosalberto carlosalberto merged commit 93df390 into open-telemetry:main May 17, 2021
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions spec:trace Related to the specification/trace directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants