Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark ExplicitBucketBoundaries hint API as stable #3391

Closed
trask opened this issue Apr 13, 2023 · 13 comments · Fixed by #3694
Closed

Mark ExplicitBucketBoundaries hint API as stable #3391

trask opened this issue Apr 13, 2023 · 13 comments · Fixed by #3694
Assignees
Labels
spec:metrics Related to the specification/metrics directory

Comments

@trask
Copy link
Member

trask commented Apr 13, 2023

What are you trying to achieve?

Mark ExplicitBucketBoundaries hint API as stable since this will be required for emitting HTTP semantic conventions now that we are changing http.server.duration and http.client.duration unit from milliseconds to seconds (see #3390).

@trask trask added the spec:metrics Related to the specification/metrics directory label Apr 13, 2023
@trask trask moved this to Blocker for HTTP semconv stability in Semantic Conventions + Instrumentation Stability WG Apr 13, 2023
@MrAlias
Copy link
Contributor

MrAlias commented Apr 13, 2023

It seems like we should have a few implementations of this API before we stabilize it, right?

@trask
Copy link
Member Author

trask commented Apr 13, 2023

ya, the HTTP semconv stability WG would be very grateful if any other languages besides Java can implement since it is required for HTTP semconv stability

@trask
Copy link
Member Author

trask commented Apr 14, 2023

@reyang will be prototyping in .NET ❤️

we will need to prototype in one more language

cc @open-telemetry/python-approvers @open-telemetry/cpp-approvers @open-telemetry/javascript-approvers @open-telemetry/go-approvers 🤞

@MrAlias
Copy link
Contributor

MrAlias commented Apr 14, 2023

Go might be able to prototype this in a few weeks if we stabilize the metric API first.

@trask
Copy link
Member Author

trask commented Jul 24, 2023

related #3621

@trask
Copy link
Member Author

trask commented Jul 24, 2023

related #3622

@legendecas
Copy link
Member

JS implementation: open-telemetry/opentelemetry-js#3876

@dyladan
Copy link
Member

dyladan commented Aug 11, 2023

JS prototype looks fine to me

@trask
Copy link
Member Author

trask commented Aug 11, 2023

@open-telemetry/dotnet-maintainers have you had a chance to prototype this in .NET? I think we just need one more (we now have Java and JS prototypes).

@MrAlias
Copy link
Contributor

MrAlias commented Aug 11, 2023

I think we need resolutions to the following issues before we can proceed with this:

@trask trask moved this from Blocker for HTTP semconv stability to Blocker for HTTP instrumentation stability in Semantic Conventions + Instrumentation Stability WG Aug 15, 2023
@trask trask moved this from Blocker for HTTP instrumentation stability to Blocker for HTTP semconv stability in Semantic Conventions + Instrumentation Stability WG Aug 15, 2023
@trask
Copy link
Member Author

trask commented Sep 12, 2023

Just checking in on this, I think we only have 2 of the 3 required prototypes needed to mark this stable:

@MrAlias
Copy link
Contributor

MrAlias commented Sep 18, 2023

@trask: Go prototype open-telemetry/opentelemetry-go#4341

Thanks @dashpole 🎉

@albertored
Copy link
Contributor

A little late but also Erlang/Elixir implementation is in PR open-telemetry/opentelemetry-erlang#628

@github-project-automation github-project-automation bot moved this from Blocker for HTTP semconv stability to Done in Semantic Conventions + Instrumentation Stability WG Sep 20, 2023
@github-project-automation github-project-automation bot moved this from Blocker for stability to Done in Spec: HTTP Semantic Conventions Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:metrics Related to the specification/metrics directory
Development

Successfully merging a pull request may close this issue.

6 participants