-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adopting ECS convention for logging spec's Trace Context in Legacy Formats #3303
Comments
Is this issue still being considered? I see elastic/ecs-logging-java#214 (comment), #3469, and #3518 suggest we are planning to keep the current field names. I'm interested in seeing https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/logging_trace_context.md reach stability, and this appears to be the only related issue. |
I think the conclusion in #3518 was that we keep the names. It has been a while and there is no new evidence that we need to do something else so I suggest that we submit a PR that declares https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/logging_trace_context.md "Stable" and closes this issue. |
PR: #3909 |
@open-telemetry/technical-committee please take a look, the PRs related to this have been auto-closed, is this something that is done or that needs additional attention? |
…elemetry#3909) Closes open-telemetry#3303 ## Changes From @tigrannajaryan in open-telemetry#3303 (comment): > I think the conclusion in open-telemetry#3518 was that we keep the names. It has been a while and there is no new evidence that we need to do something else so I suggest that we submit a PR that declares https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/compatibility/logging_trace_context.md "Stable" and closes this issue. This marks the specification for using `trace_id`, `span_id`, and `trace_flags` in non-OTLP logging formats stable.
Currently, the logging spec's Trace Context in Legacy Formats says:
I think it's worth considering using instead the ECS field names
trace.id
,span.id
andtrace.flags
.Related: open-telemetry/opentelemetry-java-instrumentation#7985
cc @AlexanderWert
The text was updated successfully, but these errors were encountered: