Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[profiles] introduce semantic convention #1188

Merged
merged 25 commits into from
Sep 3, 2024
Merged

[profiles] introduce semantic convention #1188

merged 25 commits into from
Sep 3, 2024

Conversation

florianl
Copy link
Contributor

Changes

With open-telemetry/opentelemetry-proto#534 a new OTel signal was introduced.

This change introduced semantic conventions specific to the OTel Profiling signal.

FYI: @open-telemetry/profiling-maintainers @aalexand

Merge requirement checklist

@florianl florianl requested review from a team June 27, 2024 16:03
@florianl florianl force-pushed the profiles-convention branch from 24578d4 to 2783221 Compare June 27, 2024 16:24
trask
trask reviewed Jun 28, 2024
View reviewed changes
docs/general/profiles.md Outdated Show resolved Hide resolved
model/profiles/link.yaml Outdated Show resolved Hide resolved
model/registry/profile.yaml Outdated Show resolved Hide resolved
model/registry/profile.yaml Outdated Show resolved Hide resolved
trask
trask reviewed Jun 28, 2024
View reviewed changes
model/registry/profile.yaml Outdated Show resolved Hide resolved
lmolkova
lmolkova reviewed Jun 28, 2024
View reviewed changes
docs/general/profiles.md Outdated Show resolved Hide resolved
lmolkova
lmolkova reviewed Jun 28, 2024
View reviewed changes
docs/general/profiles.md Outdated Show resolved Hide resolved
@lmolkova lmolkova mentioned this pull request Jun 28, 2024
Open
@tigrannajaryan tigrannajaryan mentioned this pull request Jul 11, 2024
Closed
@florianl florianl mentioned this pull request Jul 12, 2024
Closed
florianl added 14 commits August 8, 2024 12:03
@florianl
[profiles] introduce semantic convention
77a7f14 
Signed-off-by: Florian Lehner <[email protected]>
@florianl
fixup: update dropdown areas
412f7e7 
Signed-off-by: Florian Lehner <[email protected]>
@florianl
fixup: yamllint
e0a5bf2 
Signed-off-by: Florian Lehner <[email protected]>
@florianl
fixup: add PR number to changelog
5d9951c 
Signed-off-by: Florian Lehner <[email protected]>
@florianl
fixup: apply feedback from @trisch-me
1580868 
Signed-off-by: Florian Lehner <[email protected]>
@florianl
fixup: apply feedback from @trask
d38386d 
Signed-off-by: Florian Lehner <[email protected]>
@florianl
fixup: apply feedback from @trask
ffecd92 
Signed-off-by: Florian Lehner <[email protected]>
@florianl
fixup: apply feedback from @trask
377193e 
Signed-off-by: Florian Lehner <[email protected]>
@florianl
fixup: run markdown-toc
bec7ce7 
Signed-off-by: Florian Lehner <[email protected]>
@florianl
fixup: markdown
9870057 
Signed-off-by: Florian Lehner <[email protected]>
@florianl
fixup: remove reserved attributes
9f65c24 
Signed-off-by: Florian Lehner <[email protected]>
@florianl
fixup: drop link attributes
f632512 
Signed-off-by: Florian Lehner <[email protected]>
@florianl
fixup: fix missing DocumentStatus link
ff6aaa2 
Signed-off-by: Florian Lehner <[email protected]>
@florianl
fixup: drop prefix in attribute
7dbce84 
Signed-off-by: Florian Lehner <[email protected]>
joaopgrassi
joaopgrassi reviewed Aug 23, 2024
View reviewed changes
model/registry/profile.yaml Outdated Show resolved Hide resolved
model/registry/profile.yaml Show resolved Hide resolved
florianl and others added 5 commits August 26, 2024 07:41
florianl added a commit to florianl/opentelemetry-proto that referenced this pull request Aug 29, 2024
@florianl
profiles: drop Location.type_index
0b53e15 
With open-telemetry/semantic-conventions#1188 the semantic convention for Profiles that introduces frame types and well known values is about to be merged.

Therefore,  `Location.type_index` is no longer needed.

FYI: @open-telemetry/profiling-maintainers
This was referenced Aug 29, 2024
Merged
Open
felixge
felixge approved these changes Sep 2, 2024
View reviewed changes
model/registry/profile.yaml Show resolved Hide resolved
@AlexanderWert
Copy link
Member

@open-telemetry/specs-semconv-approvers Can we get more general approvals on this one please?
We already have a bunch of the profiling SIG's approvals, just missing an additional general semconv SIG approval.

@florianl florianl mentioned this pull request Sep 2, 2024
Closed
joaopgrassi
joaopgrassi reviewed Sep 2, 2024
View reviewed changes
model/profiles/frame.yaml Outdated Show resolved Hide resolved
docs/general/profiles.md Outdated Show resolved Hide resolved
@florianl
fixup: run make fix
b6aed34 
Signed-off-by: Florian Lehner <[email protected]>
joaopgrassi
joaopgrassi approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@joaopgrassi joaopgrassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, apart from the opt-in requirement, but I don't have a strong argument against it, so I will defer the decision to the profiling sig.

@AlexanderWert AlexanderWert merged commit 5654b20 into open-telemetry:main Sep 3, 2024
14 checks passed
tigrannajaryan added a commit to open-telemetry/opentelemetry-proto that referenced this pull request Sep 16, 2024
@florianl @tigrannajaryan
profiles: drop Location.type_index (#578)
8265a53 
With open-telemetry/semantic-conventions#1188 the semantic convention for Profiles that introduces frame types and well known values is about to be merged.

Therefore,  `Location.type_index` is no longer needed.

FYI: @open-telemetry/profiling-maintainers

Co-authored-by: Tigran Najaryan <[email protected]>
dmathieu pushed a commit to dmathieu/opentelemetry-proto that referenced this pull request Sep 23, 2024
@florianl @tigrannajaryan @dmathieu
profiles: drop Location.type_index (open-telemetry#578)
2f2b584 
With open-telemetry/semantic-conventions#1188 the semantic convention for Profiles that introduces frame types and well known values is about to be merged.

Therefore,  `Location.type_index` is no longer needed.

FYI: @open-telemetry/profiling-maintainers

Co-authored-by: Tigran Najaryan <[email protected]>
florianl added a commit to open-telemetry/opentelemetry-ebpf-profiler that referenced this pull request Sep 24, 2024
@florianl
reporter: use semantic convention to report frame type
162de1f 
With open-telemetry/semantic-conventions#1188 a
semantic convention for frame types was defined and
open-telemetry/opentelemetry-proto#578 removed
Location.type_index from the OTel profiling signal in favor of the semantic
convention.
Update the reporter to use this semantic convention.

Signed-off-by: Florian Lehner <[email protected]>
@florianl florianl mentioned this pull request Sep 24, 2024
Merged
florianl added a commit to open-telemetry/opentelemetry-ebpf-profiler that referenced this pull request Sep 24, 2024
@florianl
reporter: use semantic convention to report frame type
8bd65dd 
With open-telemetry/semantic-conventions#1188 a
semantic convention for frame types was defined and
open-telemetry/opentelemetry-proto#578 removed
Location.type_index from the OTel profiling signal in favor of the semantic
convention.
Update the reporter to use this semantic convention.

Signed-off-by: Florian Lehner <[email protected]>
@chalin chalin mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalexand aalexand aalexand left review comments

@felixge felixge felixge approved these changes

@christos68k christos68k christos68k approved these changes

@athre0z athre0z athre0z approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@brancz brancz brancz approved these changes

@AlexanderWert AlexanderWert AlexanderWert approved these changes

@petethepig petethepig petethepig approved these changes

@jsuereth jsuereth Awaiting requested review from jsuereth

@trask trask Awaiting requested review from trask

@lmolkova lmolkova Awaiting requested review from lmolkova

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan

@trisch-me trisch-me Awaiting requested review from trisch-me

Assignees

@AlexanderWert AlexanderWert

Labels
None yet
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.