Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change net attribute names to match the semantic conventions spec for http #999

Merged
merged 5 commits into from
Nov 1, 2021
Merged

fix: change net attribute names to match the semantic conventions spec for http #999

merged 5 commits into from
Nov 1, 2021

Conversation

blumamir
Copy link
Member

@blumamir blumamir commented Nov 1, 2021

fixes #998

@blumamir
Copy link
Member Author

blumamir commented Nov 1, 2021 •
edited
Loading

Thanks for the quick review @arielvalentin .
After you approved it, I noticed that the wrong attribute names are also used in other places in the codebase. Update them as well.

@blumamir blumamir changed the title fix: change net attribute names in net_http instrumentation to match spec fix: change net attribute names to match the semantic conventions spec for http Nov 1, 2021
@fbogsany fbogsany merged commit 0b1d16e into open-telemetry:main Nov 1, 2021
@github-actions github-actions bot mentioned this pull request Nov 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbogsany fbogsany fbogsany approved these changes

@arielvalentin arielvalentin arielvalentin approved these changes

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@mwear mwear Awaiting requested review from mwear mwear is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

net_http instrumentation not following semantic conventions for net.peer.name
3 participants
@blumamir @arielvalentin @fbogsany